firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Updated to latest Rust stable

Open JonathanWoollett-Light opened this issue 1 year ago • 3 comments

Reason for This PR

The current version of the Rust tool chain used in Firecracker is 1.52.0 this is over a year old and missing useful functionality.

Description of Changes

  1. Updated Rust tool chain to latest stable release.
  2. Implemented required fixes to satisfy rustc linting & clippy.
  3. WIP Looking at failing jailer tests.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PR Checklist

  • [x] All commits in this PR are signed (git commit -s).
  • [x] The issue which led to this PR has a clear conclusion.
  • [x] This PR follows the solution outlined in the related issue.
  • [x] The description of changes is clear and encompassing.
  • [x] Any required documentation changes (code and docs) are included in this PR.
  • [x] Any newly added unsafe code is properly documented.
  • [x] Any API changes follow the Runbook for Firecracker API changes.
  • [x] Any user-facing changes are mentioned in CHANGELOG.md.
  • [x] All added/changed functionality is tested.

JonathanWoollett-Light avatar Aug 03 '22 16:08 JonathanWoollett-Light

Did you remove the binding manually or re-run rust bindgen?

dianpopa avatar Aug 04 '22 10:08 dianpopa

Do we maybe want to combine this rust update with ubuntu update? I am thinking about saving some devctr entries?

dianpopa avatar Aug 04 '22 10:08 dianpopa

Did you remove the binding manually or re-run rust bindgen?

I manually removed some of the assertions within some of the tests which where flagged as UB.

Do we maybe want to combine this rust update with ubuntu update? I am thinking about saving some devctr entries?

I think in this case for making changes more incremental and faster it would be better to keep these separate.

JonathanWoollett-Light avatar Aug 04 '22 10:08 JonathanWoollett-Light

Since the plan is to do this incrementally, would it make sense to close this?

Thanks!

dianpopa avatar Mar 16 '23 11:03 dianpopa