firecracker-go-sdk Allow `--cgroup` to be passed to `jailer`

Description of changes: When setting up the jailer via firecracker-go-sdk I noticed that the SDK only supported setting a WithNumaNode to provide affinity. This change allows the WithNumaNode to be optional, which it is with the jailer. This change also adds a WithCgroupArgs option that will pass the provided arguments through to jailers --cgroup argument.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

May 17 '23 08:05 gudmundur

👋 I'm wanting the same thing, any reason you decided to not pursue this change? Is there a better way to configure cgroups via the SDK?

Dec 27 '23 14:12 adityamaru

Likewise, would love to see this in.

Jan 24 '24 01:01 maxdml

@adityamaru we're using this in production. Waiting for a maintainer here to review this. 😳

Feb 22 '24 17:02 gudmundur

@swagatbora90 @austinvazquez Any chance y'all could look into it? Seems like you folks are the most recent contributors on AWS side. Thank you!

Jun 13 '24 14:06 gs0510

@sondavidb Thank you so much for taking a look at #574, could I ask you to take a look at this PR as well? Also, it seems like a bunch of folks would also like this PR landed. Thanks again!

Jun 14 '24 08:06 gs0510

@gudmundur could you rebase and push so the tests can run again?

Jun 14 '24 20:06 sondavidb

@gudmundur friendly ping - we would like this feature as well. Are you able to rebase as @sondavidb mentioned? or if you don't have time to look at this, @sondavidb would you be open to me opening a new PR with this change?

Nov 06 '24 20:11 bduffany

Yeah that should be fine, feel free to ping when it is opened

Nov 06 '24 21:11 sondavidb

@sondavidb Thanks - I sent https://github.com/firecracker-microvm/firecracker-go-sdk/pull/600

Nov 06 '24 22:11 bduffany

Closed in favor of #600

Jan 13 '25 17:01 sondavidb