firecracker-containerd icon indicating copy to clipboard operation
firecracker-containerd copied to clipboard

Update thinpool setup script in getting-started.md

Open cauld opened this issue 4 years ago • 4 comments

Issue #, if available: N/A

Description of changes: The example thinpool setup in this guide script assumes the /var/lib/firecracker-containerd/snapshotter/devmapper directory exists. If fails if not. Added a directory check/create if needed block.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cauld avatar Dec 09 '21 23:12 cauld

Thanks, this looks good, but we need a DCO to merge.

You can use git commit -s if you've configured git to use your real name, otherwise you can manually add a line to your commit message like:

Signed-off-by: John Doe <[email protected]>

Kern-- avatar Dec 10 '21 19:12 Kern--

Added signed off

cauld avatar Dec 11 '21 14:12 cauld

The original commit and the merge are missing a sign off. Can you please rebase to remove the later commits and then modify the original commit to add the sign off?

Kern-- avatar Dec 14 '21 22:12 Kern--

@cauld, can you squash locally and force push to your branch so that all commits are signed?

austinvazquez avatar Jul 12 '22 02:07 austinvazquez