firecow
feat: add dependency proxy variables
@ANGkeith, please see the feat/add-dependency-proxy-support of my fork. (That probably supersedes this PR #1362 at this point.) It may be helpful to look at the diff relative to my fix/better-support-for-custom-gitlab-ports (which has its own PR pending into this repo).
I tried pulling the original test you made into my new branch, but it keeps failing depending on whether I've logged into gitlab.com's Dependency Proxy. If logged in, one test passes and the other fails. If logged out, vice versa. I'll leave it to you to construct the test, since it doesn't rely on any custom-port configuration. Thanks.
This is working as is for me, so it can be merged. But please look at the comments I added because there are a couple minor issues that could make this even better if addressed.
@ANGkeith, I'm really busy today so I'm not going to be able to test these changes on my instance. I should be able to get back to you tomorrow. But from my quick review just now, this looks good. Thanks.
My local test was successful. As far as I'm concerned, this is ready to be merged!
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
95.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ANGkeith Ready for review?
Hey @firecow, just wanted to keep this on your radar. IIRC correctly, GitHub doesn't notify you when someone "likes" your post, so you may not have noticed that @ANGkeith gave you a 👍 to go ahead and do the review. Or maybe you did and you're just too busy! If that's the case, sorry to bug you.