gitlab-ci-local icon indicating copy to clipboard operation
gitlab-ci-local copied to clipboard
verified publisher icon firecow

feat: Maximum nested includes

Open ANGkeith opened this issue 1 year ago • 3 comments

Implements https://docs.gitlab.com/ee/administration/settings/continuous_integration.html#maximum-includes

Breaking changes:

  • refer to the include-local-wildcard test case.

ANGkeith avatar Mar 02 '24 07:03 ANGkeith

@PigeonF cherry-picked your test-cases https://github.com/firecow/gitlab-ci-local/pull/1122/commits/3f91cd137a61c5c68cbb186c3fe684ceedcf546f

ANGkeith avatar Mar 02 '24 08:03 ANGkeith

I don't mind closing #1122 in favor of this PR.

PigeonF avatar Mar 02 '24 08:03 PigeonF

@ANGkeith Eslint failing :smile:

firecow avatar Mar 03 '24 15:03 firecow

opps, my bad... test case fixed

ANGkeith avatar Mar 07 '24 15:03 ANGkeith

@ANGkeith Do you want a collaborator invite, so you don't have to fork all the time?

firecow avatar Mar 08 '24 06:03 firecow

Can we just print a warning instead? I don't think the check here is accurate, as gitlab-ci-local fails to run a pipeline which works in our GitLab instance (at least it might count includes a bit differently?)

(Also, hard-coding it to 150 is not right. Maybe it should come from an env. variable as it can be configured in the GitLab admin)

hverlin avatar Jun 06 '24 11:06 hverlin