networkmanager-dmenu icon indicating copy to clipboard operation
networkmanager-dmenu copied to clipboard

Add --dmenu option to wofi invocation

Open hexbioc opened this issue 1 year ago • 1 comments

On Wayland, with wofi, the script fails with a cryptic error:

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_get_qdata: assertion 'G_IS_OBJECT (object)' failed

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_set_qdata_full: assertion 'G_IS_OBJECT (object)' failed

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_set_qdata_full: assertion 'G_IS_OBJECT (object)' failed

(process:100791): GLib-GObject-CRITICAL **: 18:24:27.791: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

Turns out it is due to the failure in launching wofi, as it requires the --dmenu option to operate in dmenu mode.

This PR adds the same.

PS: Please let me know if you'd like me to create an issue first!

hexbioc avatar Jun 05 '24 12:06 hexbioc

You can add --dmenu to your dmenu_command configuration, for example (see README): dmenu_command = wofi --dmenu

I would like to make nmdm a bit smarter and generalize support for each launcher so you don't have to configure common items like --dmenu. Unfortunately they all have different flags.

I'm going to leave this open as a reminder to myself to work on streamlining launcher support. Thanks for the contribution and the interest!

firecat53 avatar Jun 05 '24 23:06 firecat53

I'm not sure those error messages have anything to do with running wofi without --dmenu as I also seem to get those when running with the option (in config.ini or with the given patch). They only appear when exiting and don't seem to be affecting usage though.

winkelnp avatar Oct 27 '24 21:10 winkelnp

I (finally) added in the appropriate dmenu flags by default for all supported launchers. Thanks!

firecat53 avatar Mar 13 '25 18:03 firecat53