firecamp icon indicating copy to clipboard operation
firecamp copied to clipboard

Feat: The windows App lacks a title bar improvement

Open Nishchit14 opened this issue 1 year ago • 4 comments

The windows build lacks a title bar.
Thus, you cannot move, resize, minimize, etc. the window.

Originally posted by @Alia5 in https://github.com/firecamp-dev/firecamp/discussions/167#discussioncomment-8547378

Nishchit14 avatar Feb 22 '24 06:02 Nishchit14

I'd be happy to help out by opening a PR.

However, I don't think I have enough of an overview yet.

The quick-fix would be to set the frame property to true when calling new BrowserWindow(...)
Is this an acceptable fix for the time being, if restricted to Windows?
Or is it an issue on other platforms as well?

Should there even be a native Window-Frame shown, or is there a custom title-bar implemented that is simply now shown?

Should a custom title-bar be implemented if not already present? If so how would the platform specific look like?

Alia5 avatar Feb 22 '24 11:02 Alia5

Same issue is happening on Mac with M processor.

teckdev avatar Mar 28 '24 16:03 teckdev

@Alia5 I agree with your thought, I'll fix it by this weekend. It'll be available in the next release.

Nishchit14 avatar Mar 29 '24 18:03 Nishchit14

Hey @Nishchit14, still present.

MypowerHD avatar Aug 02 '24 13:08 MypowerHD