fireblocks-sdk-js icon indicating copy to clipboard operation
fireblocks-sdk-js copied to clipboard

Published 20 hours ago • verified publisher icon fireblocks

fix: fix types related to transactions

Open ehamery opened this issue 2 years ago • 0 comments

Update interfaces:

  • InternalWalletAsset
  • CreateTransactionResponse
  • TransactionResponse

Update comments of functions throwing:

  • getVaultAccountsWithPageInfo
  • getTransactionById

Pull Request Description

Some interfaces did not match what the API returns, therefore I fixed them.

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [X] Chore / Documentation

How Has This Been Tested?

  • [X] Locally tested against Fireblocks API

Checklist:

  • [X] I have performed a self-review of my own code
  • [X] I have made corresponding changes to the documentation
  • [X] I have added corresponding labels to the PR -> needs permission

ehamery avatar Jun 04 '22 07:06 ehamery