snippets-android icon indicating copy to clipboard operation
snippets-android copied to clipboard

startActivityForResult depricated

Open shrirampanchal opened this issue 2 years ago • 4 comments

Since startActivityForResult depricated how to target GoogleSignIn for new android versions

shrirampanchal avatar Oct 09 '21 06:10 shrirampanchal

May get around to this later, but wanted to post the relevant links that show up for fixing this and the areas I found the problem in.

https://github.com/firebase/snippets-android/blob/7268f816496dac6990b9587874520daeeba46333/auth/app/src/main/java/com/google/firebase/quickstart/auth/GoogleSignInActivity.java#L128 https://github.com/firebase/snippets-android/blob/7268f816496dac6990b9587874520daeeba46333/auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/GoogleSignInActivity.kt#L100

Links: https://developer.android.com/training/basics/intents/result https://stackoverflow.com/questions/62671106/onactivityresult-method-is-deprecated-what-is-the-alternative

MatthewFallon avatar Mar 25 '22 19:03 MatthewFallon

@MatthewFallon Let me know if you still wish to contribute :)

thatfiredev avatar Apr 13 '22 17:04 thatfiredev

Hey @thatfiredev is it to late to contribute ?

yveskalume avatar Sep 19 '23 15:09 yveskalume

@yveskalume I'm looking at our docs for Google Sign-in, and it seems like they have been updated for One Tap Sign-in and we no longer use startActivityForResult, so this should no longer be an issue. 🥲

thatfiredev avatar Sep 19 '23 15:09 thatfiredev