quickstart-ios
quickstart-ios copied to clipboard
firebase
[5-2336000026166] RegEx condition not working for User property. Working example.
Setup:
- In the firebase dashboard, create a user property called AppVersion
- In remote config, have the following parameter defined:
- Name: unsupported
- Condition: User Property AppVersion contains regex ^2.1. -> true
- default -> false
Issue: Setting the User Property to "2.10.0.0" in the application, returns true for unsupported on fetch even though the regex does not match. true should only be returned for "2.1.(anything)". The period is not being respected. The regex is valid RE2.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Sorry for the slow response here, this PR slipped through my notification inbox. Is this still an issue on Firebase 6?
Just tested with Firebase 6.2 and it's still an issue.
On Mon, Jun 17, 2019 at 3:43 PM Morgan Chen [email protected] wrote:
Sorry for the slow response here, this PR slipped through my notification inbox. Is this still an issue on Firebase 6?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/firebase/quickstart-ios/pull/689?email_source=notifications&email_token=AANJMAZYA5STG2PFCDCW3ETP27SMPA5CNFSM4HHY7WZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4HSTQ#issuecomment-502823246, or mute the thread https://github.com/notifications/unsubscribe-auth/AANJMAYECCDLVX3UPHZ3BV3P27SMPANCNFSM4HHY7WZA .
No update yet. I've pinged the bug for you, so hopefully it will get a response soon.
config/ConfigExample.xcodeproj/project.pbxproj config/ConfigExampleSwift/ViewController.swift
@shehrozkhan88 @morganchen12 Still seeing this issue with the latest remote config example and firebase 7.2. Code changes have been added in my branch.
Hey, apologies for the slow response. I was only able to reproduce this with regex ^2.1., not ^2\.1\.. Seems to be working as intended. Please re-open if that's not the case.