firebase
chore[js]: move `@types` packages to `devDependencies` without modifying packages version
Description here... Help the reviewer by:
- linking to an issue that includes more details
- if it's a new feature include samples of how to use the new feature
- (optional if issue link is provided) if you fixed a bug include basic bug details
Checklist (if applicable):
- [x] PR title is following https://www.conventionalcommits.org/en/v1.0.0/
- [ ] Tested (manually, unit tested, etc.)
- [ ] Docs updated (updated docs or a docs bug required)
Why do this? Most guidance I've seen is to put this in deps, not devDeps. I think there's too much risk for no enumerated benefit
On Sun, Apr 6, 2025, 3:41 PM Yesudeep Mangalapilly @.***> wrote:
@yesudeep https://github.com/yesudeep requested your review on: #2659 https://github.com/firebase/genkit/pull/2659 chore[js]: move @types packages to devDependencies without modifying packages version.
— Reply to this email directly, view it on GitHub https://github.com/firebase/genkit/pull/2659#event-17144480530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAH7XGEW6CHIH2Y6LJOI32YGURFAVCNFSM6AAAAAB2QTDEIGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGE2DINBYGA2TGMA . You are receiving this because your review was requested.Message ID: @.***>
@mbleigh Thanks for your comment
Based on npmjs official docs
"devDependencies": Packages that are only needed for local development and testing.
@types/xxx packages are only needed for local development and testing, so I think these packages should be moved to devDependencies