genkit icon indicating copy to clipboard operation
genkit copied to clipboard

[Go] Allow users to provide custom http configuration to go-genai client

Open hugoaguirre opened this issue 9 months ago • 2 comments

Allow users to provide custom HTTP configuration and Google Credentials to go-genai client https://github.com/googleapis/go-genai/blob/main/client.go#L70C3-L72C4

Currently, API_KEY, ProjectID and Location are available to be used but HTTP config and Google Credentials are not.

hugoaguirre avatar Mar 12 '25 19:03 hugoaguirre

Hi, would like to try out solving this issue! can you please assign this to me @hugoaguirre ? Thanks !

iks1 avatar May 25 '25 14:05 iks1

Hi, I had raised a PR for this issue, it's PR #324. First open source contribution.

nair-shubh avatar May 26 '25 19:05 nair-shubh

Hello, I have been working on a fix for this issue. I believe the change is needed in the underlying go-genai library, so I have opened a pull request there: https://github.com/googleapis/go-genai/pull/324 . Could you please advise if this is the correct approach, or if I should re-submit this PR to the firebase/genkit repository? Thank you!

nair-shubh avatar Jun 07 '25 09:06 nair-shubh

Hello @iks1, @shubham-nair. Thanks for your interest in contributing to this project!

Unfortunately this issue was created when we were using custom types to interact with the go-genai SDK. Now that we are directly using go-genai types (#2958 ), this issue is no longer applicable.

However, @shubham-nair your contribution to go-genai is still valuable!

I'll try to tag issues as good-first-issue for future contributions!

hugoaguirre avatar Jun 17 '25 13:06 hugoaguirre

@hugoaguirre Thank you. I will be looking forward to contributing more!

nair-shubh avatar Jun 17 '25 20:06 nair-shubh