flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

chore(firebase_dynamic_links): update example app proving deeplink works from terminated app state

Open russellwheatley opened this issue 1 year ago • 1 comments

Description

Fix dynamic links example app. This also proves that the GoogleService-Info.plist is not necessary for deeplink to resolve.

Related Issues

closes https://github.com/firebase/flutterfire/issues/9110

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ ] All existing and new tests are passing.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] The analyzer (melos run analyze) does not report any problems on my PR.
  • [ ] I read and followed the Flutter Style Guide.
  • [ ] I signed the CLA.
  • [ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [X] No, this is not a breaking change.

russellwheatley avatar Jul 28 '22 15:07 russellwheatley

Maybe we can add

  • It needs to be run in release mode (i.e. flutter run --release) if you wish to test it from a terminated app state.
  • It needs to run on an actual device. from your comment to the README?

Lyokone avatar Jul 29 '22 04:07 Lyokone