flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

fix(firebase_auth): use correct UTC time from server for `currentUser?.metadata.creationTime` & `currentUser?.metadata.lastSignInTime`

Open russellwheatley opened this issue 1 year ago • 0 comments

Description

// On firebase-admin (server)
console.log(user.metadata.creationTime); // Mon, 18 Jul 2022 10:17:31 GMT
// As currently implemented
print('${DateTime.fromMillisecondsSinceEpoch(_creationTimestamp!)}'); // 2022-07-18 11:17:31.699

// Fix
print('${DateTime.fromMillisecondsSinceEpoch(_creationTimestamp!, isUtc: true)}'); // 2022-07-18 10:17:31.699Z


Related Issues

fixes https://github.com/firebase/flutterfire/issues/9162

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ ] All existing and new tests are passing.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] The analyzer (melos run analyze) does not report any problems on my PR.
  • [ ] I read and followed the Flutter Style Guide.
  • [ ] I signed the CLA.
  • [ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [X] No, this is not a breaking change.

russellwheatley avatar Jul 28 '22 09:07 russellwheatley