flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

ci: fix CI for branch `migrate-to-integration-tests`

Open nilsreichardt opened this issue 3 years ago • 0 comments

Description

7ba3141ecde739eef94eb677abd9b0a1f905aa1c has broken the CI. This PR should fix it.

ToDo:

  • [ ] Moved firebase_dynamic_links into own workflow

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ ] All existing and new tests are passing.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] The analyzer (melos run analyze) does not report any problems on my PR.
  • [ ] I read and followed the Flutter Style Guide.
  • [ ] I signed the CLA.
  • [ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [ ] No, this is not a breaking change.

nilsreichardt avatar Jul 20 '22 10:07 nilsreichardt

I think it makes sense to just merge this PR (it just a PR for a feature branch), merge the master again into migrate-to-integration-test and then fix again the remaining issues.

nilsreichardt avatar Aug 21 '22 19:08 nilsreichardt