flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

[flutterfire_ui] Social media failing on RegisterScreen

Open kevin-induro opened this issue 2 years ago • 5 comments

Bug report

This was previously reported in https://github.com/firebase/flutterfire/issues/8219

I don't have much to add to the bug beyond what was initially reported.

Steps to reproduce

I experienced this while working with Google Sign In, but it should how true to anything using the AuthFlow class.

  1. Download the FlutterFire UI example.
  2. Update project with the appropriate Firebase/Google Sign In configurations
  3. Sign In works as expected, Register Shows "An unknown error occurred"

Expected behavior

This depends on how we want to semantically consider things. On one hand, you could consider that AuthAction.signIn and AuthAction.signUp should be the same thing in these cases because there is no difference in implementation.

On the other hand, you could argue that they are different. In that case, either we could continue to block signup, or we could implement a signup. If we continue to block signup, that necessitates a change to the RegisterScreen - it shouldn't present the social options if they're always going to error.

Sample project

https://github.com/firebase/flutterfire/tree/master/packages/flutterfire_ui/example

kevin-induro avatar Jul 08 '22 15:07 kevin-induro

@kevin-induro Thanks for the report. I tried the flutterfire_ui example using latest flutter master version and ran it on iphone simulator with which I was able to register properly as shown below:

Screenshot 2022-07-11 at 1 23 31 PM

In your case, is it happening on Android or iOS ?

darshankawar avatar Jul 11 '22 07:07 darshankawar

I ran it on Android.

How did you accomplish that? Can you share a video? It seems to be really clear in the code where it's disallowing the AuthAction.signUp method. line 126: https://github.com/firebase/flutterfire/blob/master/packages/flutterfire_ui/lib/src/auth/auth_flow.dart

kevin-induro avatar Jul 11 '22 14:07 kevin-induro

Thanks for the update. After I updated the plugin example with my configuration, ie, app name and firebaseOptions and running on Android, I am seeing same behavior as reported. The sign-in is working as expected, but with Register, it seems to be throwing an unknown error occured.

darshankawar avatar Jul 12 '22 07:07 darshankawar

/cc @lesnitsky

darshankawar avatar Jul 12 '22 07:07 darshankawar

This is quite a big annoying bug preventing apps from passing reviews in the AppStore. Any chance we can get the progress of this? @darshankawar @lesnitsky or how can I be of help to help sort out this bug as it affects all the federated social logins including Apple Sign In etc. I can confirm this does not affect Android alone, it also affects iOS.

ronnicknachok avatar Aug 04 '22 07:08 ronnicknachok