flutterfire
flutterfire copied to clipboard
feat(remote_config): Migrate firebase_remote_config iOS and Android to Pigeon
This commit migrates the native communication layer for the firebase_remote_config plugin on iOS and Android from MethodChannel to Pigeon.
Work Done:
- Defined Pigeon API: Created
messages.pigeonin the platform interface package, defining the Host API (FirebaseRemoteConfigHostApi) and data structures based on the existing MethodChannel methods. - Configured Pigeon Generation: Updated
messages.pigeonwith@ConfigurePigeonto specify output paths for Dart, Swift, and Kotlin in the mainfirebase_remote_configpackage. (Note: Actual generation was not performed due to tool limitations). - Implemented iOS Pigeon Host API: Refactored
FLTFirebaseRemoteConfigPlugin.m(Objective-C) to implement theFirebaseRemoteConfigHostApiprotocol generated by Pigeon. Replaced MethodChannel handling with Pigeon API calls, adapting helper methods and updating plugin registration. EventChannel logic foronConfigUpdatedremains. - Implemented Android Pigeon Host API: Refactored
FirebaseRemoteConfigPlugin.javato implement theFirebaseRemoteConfigHostApiinterface generated by Pigeon. Replaced MethodChannel handling, adapted helper methods, converted data types, and updated plugin registration to use Pigeon. EventChannel logic remains.
Next Steps (Incomplete):
The Dart side implementation is pending:
- Update Dart Platform Interface: Create a new Dart class (
PigeonFirebaseRemoteConfig) extendingFirebaseRemoteConfigPlatformin thefirebase_remote_config_platform_interfacepackage. This class should use the generated Dart Pigeon client (messages.g.dart) to call the native Host APIs. - Update Main Plugin Dart Code: Update
firebase_remote_config's main Dart code to use the newPigeonFirebaseRemoteConfigimplementation. - Remove MethodChannel Code: Delete the old MethodChannel implementation files in the platform interface package.
- Testing: Run existing tests and potentially add new ones for Pigeon integration.
This includes the completed native iOS and Android migrations. Further work is needed on the Dart side to fully utilize the Pigeon implementation.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.
- [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
- [ ] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with
///). - [ ] The analyzer (
melos run analyze) does not report any problems on my PR. - [ ] I read and followed the Flutter Style Guide.
- [ ] I signed the CLA.
- [ ] I am willing to follow-up on review comments in a timely manner.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
- [ ] Yes, this is a breaking change.
- [ ] No, this is not a breaking change.