flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

fix(firebase_analytics): allow `logEvent` to accept `items` inside `parameters`

Open nikitadol opened this issue 1 year ago • 0 comments

Description

Before this PR: logEvent did not accept items inside parameters After this PR: logEvent can accept items inside parameters

Reason for this PR: On my project, our backend can send all data for analytics event, including items - this PR extends checks in _assertParameterTypesAreCorrect to allow this behavior

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [x] All existing and new tests are passing.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] The analyzer (melos run analyze) does not report any problems on my PR.
  • [x] I read and followed the Flutter Style Guide.
  • [x] I signed the CLA.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [x] No, this is not a breaking change.

nikitadol avatar Sep 29 '24 19:09 nikitadol