flutterfire
flutterfire copied to clipboard
fix(auth, web): get auth credential from exception and pass to user if one is available
Description
I tested this with user's example and it worked as intended. The JS error is correctly parsed and instantiated as a Dart credential if it exists. If not, null is passed as credential which is a nullable argument on FirebaseAuthException:
final AuthCredential? credential;
Related Issues
fixes https://github.com/firebase/flutterfire/issues/12771
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.
- [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
- [ ] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with
///). - [ ] The analyzer (
melos run analyze) does not report any problems on my PR. - [ ] I read and followed the Flutter Style Guide.
- [ ] I signed the CLA.
- [ ] I am willing to follow-up on review comments in a timely manner.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
- [ ] Yes, this is a breaking change.
- [ ] No, this is not a breaking change.
Waiting for this PR to be merged, thanks @russellwheatley .