flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

feat(auth, windows): add support for oAuth with credentials on Windows

Open rohitsangwan01 opened this issue 1 year ago • 1 comments

Description

Fix crash caused when trying to use firebase auth signInWithCredential on windows

To Reproduce Crash On Windows

await FirebaseAuth.instance.signInWithCredential(
  OAuthProvider('oidc.provider').credential(
    idToken: idToken,
    accessToken: accessToken,
  )
);

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [x] All existing and new tests are passing.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] The analyzer (melos run analyze) does not report any problems on my PR.
  • [x] I read and followed the Flutter Style Guide.
  • [x] I signed the CLA.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [x] No, this is not a breaking change.

rohitsangwan01 avatar Jan 12 '24 10:01 rohitsangwan01

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 12 '24 10:01 google-cla[bot]

Wow, that's exactly what I was searching for !

Skyost avatar Mar 19 '24 08:03 Skyost

Thanks for this. It should have been merged before 👍 It will be release as part of next release

Lyokone avatar Mar 19 '24 09:03 Lyokone