flutterfire
flutterfire copied to clipboard
chore(auth): Removed redundant `languageCode` null-check.
Description
` String? get languageCode { if (_delegate.languageCode != null) { return _delegate.languageCode; }
return null;
}`
This code has a redundant check. Getter languageCode will always return String? for _delegate.languageCode. It is more easier to understand the simple and straight logic if is done as:
String? get languageCode { return _delegate.languageCode; }
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.
- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
- [x] All existing and new tests are passing.
- [x] I updated/added relevant documentation (doc comments with
///). - [x] The analyzer (
melos run analyze) does not report any problems on my PR. - [x] I read and followed the [Flutter Style Guide].
- [x] I signed the [CLA].
- [x] I am willing to follow-up on review comments in a timely manner.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
- [ ] Yes, this is a breaking change.
- [x ] No, this is not a breaking change.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
hey @Naveed-dev30, if you sign the CLA, we can look to get this merged. Thanks 👍
Hey @russellwheatley thanks for the reminder. I have signed. Kindly merge my PR.