firebase
fix(functions): Set serviceAccount for Cloud Functions when custom service account is specified
Fixes 8841
Description
When deploying Cloud Functions v2 with a custom service account specified via setGlobalOptions({ serviceAccount: "..." }), the Firebase CLI fails if the default compute service account has been deleted.
Scenarios Tested
- Custom SA sets both buildConfig.serviceAccount and serviceConfig.serviceAccountEmail
- Shorthand SA notation (sa@) expands correctly
- serviceAccount: null sets both fields to null
- No SA specified — buildConfig.serviceAccount is omitted
Sample Commands
Summary of Changes
Hello @HassanBahati, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical deployment failure for Cloud Functions v2 by ensuring that custom service accounts are properly applied to the function's build configuration. This change prevents issues arising from the absence of a default compute service account, making deployments more robust when specific service accounts are mandated.
Highlights
- Bug Fix: Resolves an issue where deploying Cloud Functions v2 with a custom service account would fail if the default compute service account had been deleted.
- Service Account Configuration: Ensures that the
buildConfig.serviceAccountfield is correctly set for Cloud Functions when a custom service account is specified, allowing the build process to use the designated service account. - Code Changes: The
BuildConfiginterface incloudfunctionsv2.tsnow includes an optionalserviceAccountfield, and thefunctionFromEndpointutility has been updated to populate this field based on the endpoint's service account. - Testing: New test cases have been added to
cloudfunctionsv2.spec.tsto validate the correct assignment ofbuildConfig.serviceAccountwhen a custom service account is provided.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
![gemini-code-assist[bot] avatar](https://avatars.githubusercontent.com/in/956858?v=4 "Published by a pub.dev verified publisher"){kind=small}
It looks like you tried to invoke a command, but you didn't specify which one. Please use /gemini <command> with one of the following commands:
/gemini review: Performs a code review for the current pull request in its current state./gemini summary: Provides a summary of the current pull request in its current state./gemini help: Displays a list of available commands.