firebase-tools
firebase-tools copied to clipboard
Print error message in terminal when function deploy fails
Description
This fixes #3473, to promote function deployment errors to the terminal. Right now they are hidden unless you look deep into debug logs.
Scenarios Tested
- Have a TypeScript project which unintentionally uses a mix of yarn.lock and package-lock.json
- Deploy a Cloud Function
- Observe error appearing in the deployment results screen

I've resolved build/test issues
Codecov Report
Base: 56.67% // Head: 55.86% // Decreases project coverage by -0.80% :warning:
Coverage data is based on head (
9ec1652) compared to base (36c0ba1). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #5029 +/- ##
==========================================
- Coverage 56.67% 55.86% -0.81%
==========================================
Files 291 305 +14
Lines 19344 20326 +982
Branches 3856 4096 +240
==========================================
+ Hits 10963 11356 +393
- Misses 7453 8014 +561
- Partials 928 956 +28
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/deploy/functions/release/index.ts | 26.66% <0.00%> (-0.92%) |
:arrow_down: |
| src/emulator/functionsRuntimeWorker.ts | 65.00% <0.00%> (-5.40%) |
:arrow_down: |
| src/gcp/run.ts | 75.60% <0.00%> (-4.02%) |
:arrow_down: |
| src/deploy/functions/build.ts | 56.28% <0.00%> (-3.47%) |
:arrow_down: |
| src/deploy/functions/cache/hash.ts | 88.88% <0.00%> (-3.42%) |
:arrow_down: |
| src/emulator/emulatorLogger.ts | 31.14% <0.00%> (-3.28%) |
:arrow_down: |
| src/deploy/functions/prepareFunctionsUpload.ts | 28.30% <0.00%> (-2.81%) |
:arrow_down: |
| src/deploy/functions/functionsDeployHelper.ts | 88.15% <0.00%> (-1.85%) |
:arrow_down: |
| src/extensions/updateHelper.ts | 75.75% <0.00%> (-1.26%) |
:arrow_down: |
| src/frameworks/index.ts | 15.24% <0.00%> (-1.15%) |
:arrow_down: |
| ... and 56 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.