firebase-tools
firebase-tools copied to clipboard
Updates Google rawUserInfo to be closer to production
Description
Fixes https://github.com/firebase/firebase-tools/issues/4756. Changes id
-> sub
and verified_email
-> email_verified
for Google provider
Scenarios Tested
npm run test
passes
Sample Commands
N/A
Codecov Report
Merging #4783 (624439e) into master (ae788e7) will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #4783 +/- ##
==========================================
+ Coverage 57.70% 57.71% +0.01%
==========================================
Files 287 287
Lines 18583 18583
Branches 3639 3639
==========================================
+ Hits 10723 10725 +2
+ Misses 6985 6983 -2
Partials 875 875
Impacted Files | Coverage Δ | |
---|---|---|
src/emulator/auth/operations.ts | 83.47% <ø> (ø) |
|
src/emulator/auth/state.ts | 85.35% <0.00%> (+0.56%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ae788e7...624439e. Read the comment docs.
Let's hold off on this and discuss internally. I believe the Google OIDC endpoints can return either
email_verified
orverified_email
depending on the endpoint being called -- search for both terms here: https://github.com/googleapis/google-api-go-client/blob/main/oauth2/v1/oauth2-api.jsonThis may be related to whether ID token or access token is being used during sign-in.
Ahh interesting, sounds good, will hold off for now, thanks for pointing that out!