firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

Improve `withFunctionTriggersDisabled` error message when Cloud Functions emulator is not running

Open gustavopch opened this issue 3 years ago • 3 comments

Related issues

None.

[REQUIRED] Version info

node: 12.22.3

firebase-functions: 3.14.1

firebase-tools: 9.16.0

firebase-admin: 9.10.0

[REQUIRED] Test case

Not sure what to write here.

[REQUIRED] Steps to reproduce

Use withFunctionTriggersDisabled to run something while the Cloud Functions emulator is not running (for example, because you mistakenly started the emulator suite with --only firestore instead of --only firestore,functions).

[REQUIRED] Expected behavior

A specific error message saying that the emulator could not be reached or something like that, .e.g: Ensure the Cloud Functions emulator is running.

[REQUIRED] Actual behavior

A generic and misleading error message saying HTTP Error 400 when disabling functions triggers, are you using firebase-tools 8.13.0 or higher?.

Were you able to successfully deploy your functions?

I'm not deploying, just testing locally.

gustavopch avatar Aug 13 '21 18:08 gustavopch

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar Aug 13 '21 18:08 google-oss-bot

@abeisgoat can you take a look into this?

i14h avatar Aug 16 '21 19:08 i14h

Reassigning to @joehan as I believe this was mistakenly tagged as a Storage emulator issue whereas it seems to apply to the Functions emulator.

tonyjhuang avatar Jul 29 '22 04:07 tonyjhuang

Filing the issue in firebase-js-sdk where withFunctionTriggersDisabled is implemented instead.

taeold avatar Dec 29 '22 21:12 taeold