firebase-tools-ui
firebase-tools-ui copied to clipboard
firebase
fix: replace hardcoded base url protocol to use client-side protocol
Also ran into this problem today. I'm running the emulator in a local MiniKube cluster behind TLS and I get a bunch of HTTPS/WSS errors. Is there anything blocking this PR?
Also ran into this problem today. I'm running the emulator in a local MiniKube cluster behind TLS and I get a bunch of HTTPS/WSS errors. Is there anything blocking this PR?
This PR is in a great shape, except there are extra colons in a few places. Other places should make use of protocol-relative URLs (mostly code style nits). We'd also appreciate more testing for this broad change and you can definitely help speed this up by patching the suggested changes and testing locally to make sure it works on all tabs (emulators) touched.
Thanks for taking a look and reviewing the PR @yuchenshi, I have applied and committed your suggestions. I haven't had the chance to test all emulators locally yet as my local development setup doesn't use this anymore. Hopefully I will have the time to test it in the coming week.
@yuchenshi Gave testing this a go today. I managed to load up the UI over https without any issues, but I'm still having some internal connectivity problems. I've logged a new issue so as not to clog up the PR.
I'm not 100% sure how, but this PR seems to break Storage unit tests: https://github.com/firebase/firebase-tools-ui/runs/6278540877?check_suite_focus=true#step:5:2864
Also: linter
We've made a huge update to the codebase and this PR is outdated. I'm redoing the proposed changes in #858 -- stay tuned and you're welcome to test on that branch to see if that works for you. The goal is to get it merged for real this time.
I'm not 100% sure how, but this PR seems to break Storage unit tests: https://github.com/firebase/firebase-tools-ui/runs/6278540877?check_suite_focus=true#step:5:2864
Found it -- caused by the fetch mocking failing since the URLs no longer start with http. Fixing in #858 as well.
Released in CLI v11.14.0. It's not perfect, especially not all emulators work over HTTPS, but we think it's a step in the right direction. Let us know if you run into issues and PRs are welcomed!