firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Removed unnecessary types

Open maneesht opened this issue 1 month ago • 3 comments

Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • Hid the constructor to FDC, which isn't intended to be used anyways
  • Un-exported DataConnectOptions

maneesht avatar Nov 10 '25 22:11 maneesht

🦋 Changeset detected

Latest commit: c087753b0d12438be2df86089dfe1172f9b581df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/data-connect Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 10 '25 22:11 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (0800a8b)Merge (8400f2a)Diff
    browser21.5 kB21.4 kB-53 B (-0.2%)
    main23.7 kB23.6 kB-53 B (-0.2%)
    module21.5 kB21.4 kB-53 B (-0.2%)
  • @firebase/remote-config

    TypeBase (0800a8b)Merge (8400f2a)Diff
    browser39.0 kB41.5 kB+2.47 kB (+6.3%)
    main40.2 kB42.7 kB+2.47 kB (+6.1%)
    module39.0 kB41.5 kB+2.47 kB (+6.3%)
  • bundle

    TypeBase (0800a8b)Merge (8400f2a)Diff
    remote-config (getAndFetch)59.4 kB61.0 kB+1.58 kB (+2.7%)
  • firebase

    TypeBase (0800a8b)Merge (8400f2a)Diff
    firebase-compat.js809 kB811 kB+1.50 kB (+0.2%)
    firebase-data-connect.js22.6 kB22.5 kB-46 B (-0.2%)
    firebase-remote-config-compat.js38.7 kB40.2 kB+1.50 kB (+3.9%)
    firebase-remote-config.js43.5 kB45.1 kB+1.55 kB (+3.6%)

Test Logs

google-oss-bot avatar Nov 10 '25 23:11 google-oss-bot

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • CallerSdkTypeEnum

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • Code

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • DataConnect

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • DataConnectError

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • DataConnectOperationError

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • MUTATION_STR

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.5 kB30.4 kB-46 B (-0.2%)
    • MutationManager

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • QUERY_STR

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • SOURCE_CACHE

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • SOURCE_SERVER

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • areTransportOptionsEqual

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • connectDataConnectEmulator

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.6 kB12.6 kB-46 B (-0.4%)
      size-with-ext-deps35.0 kB35.0 kB-46 B (-0.1%)
    • executeMutation

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.5 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.5 kB30.5 kB-46 B (-0.2%)
    • executeQuery

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.5 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.5 kB30.5 kB-46 B (-0.2%)
    • getDataConnect

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size13.1 kB13.1 kB-46 B (-0.4%)
      size-with-ext-deps38.0 kB38.0 kB-46 B (-0.1%)
    • mutationRef

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.5 kB12.5 kB-46 B (-0.4%)
      size-with-ext-deps30.6 kB30.5 kB-46 B (-0.2%)
    • parseOptions

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.4 kB30.4 kB-46 B (-0.2%)
    • queryRef

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.5 kB12.5 kB-46 B (-0.4%)
      size-with-ext-deps30.6 kB30.5 kB-46 B (-0.2%)
    • setLogLevel

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.5 kB30.4 kB-46 B (-0.2%)
    • subscribe

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size13.7 kB13.6 kB-46 B (-0.3%)
      size-with-ext-deps38.6 kB38.6 kB-46 B (-0.1%)
    • terminate

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.4 kB12.4 kB-46 B (-0.4%)
      size-with-ext-deps30.5 kB30.4 kB-46 B (-0.2%)
    • toQueryRef

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size13.3 kB13.3 kB-46 B (-0.3%)
      size-with-ext-deps38.2 kB38.2 kB-46 B (-0.1%)
    • validateArgs

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size13.3 kB13.2 kB-46 B (-0.3%)
      size-with-ext-deps38.2 kB38.2 kB-46 B (-0.1%)
    • validateDCOptions

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size12.6 kB12.6 kB-46 B (-0.4%)
      size-with-ext-deps30.7 kB30.6 kB-46 B (-0.1%)
  • @firebase/remote-config

    • activate

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.5 kB25.1 kB+1.57 kB (+6.7%)
      size-with-ext-deps50.0 kB51.6 kB+1.58 kB (+3.2%)

      Dependency

      TypeBase (0800a8b)Merge (8400f2a)Diff
      classes

      12 dependencies

      CachingClient
      EventEmitter
      InMemoryStorage
      IndexedDbStorage
      RealtimeHandler
      RemoteConfig
      RemoteConfigAbortSignal
      RestClient
      RetryingClient
      Storage
      StorageCache
      VisibilityMonitor

      13 dependencies

      CachingClient
      EventEmitter
      Experiment
      InMemoryStorage
      IndexedDbStorage
      RealtimeHandler
      RemoteConfig
      RemoteConfigAbortSignal
      RestClient
      RetryingClient
      Storage
      StorageCache
      VisibilityMonitor

      + Experiment
    • ensureInitialized

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.1 kB23.5 kB+347 B (+1.5%)
      size-with-ext-deps49.6 kB50.0 kB+347 B (+0.7%)
    • fetchAndActivate

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size24.2 kB25.7 kB+1.58 kB (+6.5%)
      size-with-ext-deps50.7 kB52.2 kB+1.58 kB (+3.1%)

      Dependency

      TypeBase (0800a8b)Merge (8400f2a)Diff
      classes

      12 dependencies

      CachingClient
      EventEmitter
      InMemoryStorage
      IndexedDbStorage
      RealtimeHandler
      RemoteConfig
      RemoteConfigAbortSignal
      RestClient
      RetryingClient
      Storage
      StorageCache
      VisibilityMonitor

      13 dependencies

      CachingClient
      EventEmitter
      Experiment
      InMemoryStorage
      IndexedDbStorage
      RealtimeHandler
      RemoteConfig
      RemoteConfigAbortSignal
      RestClient
      RetryingClient
      Storage
      StorageCache
      VisibilityMonitor

      + Experiment
    • fetchConfig

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.7 kB24.1 kB+347 B (+1.5%)
      size-with-ext-deps50.2 kB50.6 kB+347 B (+0.7%)
    • getAll

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size24.3 kB24.7 kB+347 B (+1.4%)
      size-with-ext-deps50.8 kB51.1 kB+347 B (+0.7%)
    • getBoolean

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size24.2 kB24.5 kB+347 B (+1.4%)
      size-with-ext-deps50.7 kB51.0 kB+347 B (+0.7%)
    • getNumber

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size24.2 kB24.5 kB+347 B (+1.4%)
      size-with-ext-deps50.7 kB51.0 kB+347 B (+0.7%)
    • getRemoteConfig

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.9 kB24.3 kB+347 B (+1.5%)
      size-with-ext-deps57.3 kB57.7 kB+347 B (+0.6%)
    • getString

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size24.2 kB24.5 kB+347 B (+1.4%)
      size-with-ext-deps50.7 kB51.0 kB+347 B (+0.7%)
    • getValue

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size24.1 kB24.5 kB+347 B (+1.4%)
      size-with-ext-deps50.6 kB51.0 kB+347 B (+0.7%)
    • isSupported

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.3 kB23.6 kB+347 B (+1.5%)
      size-with-ext-deps49.7 kB50.1 kB+347 B (+0.7%)
    • onConfigUpdate

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.3 kB23.6 kB+347 B (+1.5%)
      size-with-ext-deps49.7 kB50.1 kB+347 B (+0.7%)
    • setCustomSignals

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.6 kB24.0 kB+347 B (+1.5%)
      size-with-ext-deps50.1 kB50.5 kB+347 B (+0.7%)
    • setLogLevel

      Size

      TypeBase (0800a8b)Merge (8400f2a)Diff
      size23.3 kB23.6 kB+347 B (+1.5%)
      size-with-ext-deps49.8 kB50.1 kB+347 B (+0.7%)

Test Logs

google-oss-bot avatar Nov 10 '25 23:11 google-oss-bot