firebase-js-sdk
firebase-js-sdk copied to clipboard
Removed unnecessary types
Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:
Discussion
- Read the contribution guidelines (CONTRIBUTING.md).
- If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.
Testing
- Make sure all existing tests in the repository pass after your change.
- If you fixed a bug or added a feature, add a new test to cover your code.
API Changes
- Hid the constructor to FDC, which isn't intended to be used anyways
- Un-exported DataConnectOptions
🦋 Changeset detected
Latest commit: c087753b0d12438be2df86089dfe1172f9b581df
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @firebase/data-connect | Patch |
| firebase | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Size Report 1
Affected Products
@firebase/data-connectType Base (0800a8b) Merge (8400f2a) Diff browser 21.5 kB 21.4 kB -53 B (-0.2%) main 23.7 kB 23.6 kB -53 B (-0.2%) module 21.5 kB 21.4 kB -53 B (-0.2%) @firebase/remote-configType Base (0800a8b) Merge (8400f2a) Diff browser 39.0 kB 41.5 kB +2.47 kB (+6.3%) main 40.2 kB 42.7 kB +2.47 kB (+6.1%) module 39.0 kB 41.5 kB +2.47 kB (+6.3%) bundleType Base (0800a8b) Merge (8400f2a) Diff remote-config (getAndFetch) 59.4 kB 61.0 kB +1.58 kB (+2.7%) firebaseType Base (0800a8b) Merge (8400f2a) Diff firebase-compat.js 809 kB 811 kB +1.50 kB (+0.2%) firebase-data-connect.js 22.6 kB 22.5 kB -46 B (-0.2%) firebase-remote-config-compat.js 38.7 kB 40.2 kB +1.50 kB (+3.9%) firebase-remote-config.js 43.5 kB 45.1 kB +1.55 kB (+3.6%)
Test Logs
Size Analysis Report 1
Affected Products
@firebase/data-connectCallerSdkTypeEnumSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) CodeSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) DataConnectSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) DataConnectErrorSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) DataConnectOperationErrorSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) MUTATION_STRSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.5 kB 30.4 kB -46 B (-0.2%) MutationManagerSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) QUERY_STRSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) SOURCE_CACHESize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) SOURCE_SERVERSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) areTransportOptionsEqualSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) connectDataConnectEmulatorSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.6 kB 12.6 kB -46 B (-0.4%) size-with-ext-deps 35.0 kB 35.0 kB -46 B (-0.1%) executeMutationSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.5 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.5 kB 30.5 kB -46 B (-0.2%) executeQuerySize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.5 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.5 kB 30.5 kB -46 B (-0.2%) getDataConnectSize
Type Base (0800a8b) Merge (8400f2a) Diff size 13.1 kB 13.1 kB -46 B (-0.4%) size-with-ext-deps 38.0 kB 38.0 kB -46 B (-0.1%) mutationRefSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.5 kB 12.5 kB -46 B (-0.4%) size-with-ext-deps 30.6 kB 30.5 kB -46 B (-0.2%) parseOptionsSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.4 kB 30.4 kB -46 B (-0.2%) queryRefSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.5 kB 12.5 kB -46 B (-0.4%) size-with-ext-deps 30.6 kB 30.5 kB -46 B (-0.2%) setLogLevelSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.5 kB 30.4 kB -46 B (-0.2%) subscribeSize
Type Base (0800a8b) Merge (8400f2a) Diff size 13.7 kB 13.6 kB -46 B (-0.3%) size-with-ext-deps 38.6 kB 38.6 kB -46 B (-0.1%) terminateSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.4 kB 12.4 kB -46 B (-0.4%) size-with-ext-deps 30.5 kB 30.4 kB -46 B (-0.2%) toQueryRefSize
Type Base (0800a8b) Merge (8400f2a) Diff size 13.3 kB 13.3 kB -46 B (-0.3%) size-with-ext-deps 38.2 kB 38.2 kB -46 B (-0.1%) validateArgsSize
Type Base (0800a8b) Merge (8400f2a) Diff size 13.3 kB 13.2 kB -46 B (-0.3%) size-with-ext-deps 38.2 kB 38.2 kB -46 B (-0.1%) validateDCOptionsSize
Type Base (0800a8b) Merge (8400f2a) Diff size 12.6 kB 12.6 kB -46 B (-0.4%) size-with-ext-deps 30.7 kB 30.6 kB -46 B (-0.1%)
@firebase/remote-configactivateSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.5 kB 25.1 kB +1.57 kB (+6.7%) size-with-ext-deps 50.0 kB 51.6 kB +1.58 kB (+3.2%) Dependency
Type Base (0800a8b) Merge (8400f2a) Diff classes 12 dependencies
CachingClient EventEmitter InMemoryStorage IndexedDbStorage RealtimeHandler RemoteConfig RemoteConfigAbortSignal RestClient RetryingClient Storage StorageCache VisibilityMonitor
13 dependencies
CachingClient EventEmitter Experiment InMemoryStorage IndexedDbStorage RealtimeHandler RemoteConfig RemoteConfigAbortSignal RestClient RetryingClient Storage StorageCache VisibilityMonitor
+ ExperimentensureInitializedSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.1 kB 23.5 kB +347 B (+1.5%) size-with-ext-deps 49.6 kB 50.0 kB +347 B (+0.7%) fetchAndActivateSize
Type Base (0800a8b) Merge (8400f2a) Diff size 24.2 kB 25.7 kB +1.58 kB (+6.5%) size-with-ext-deps 50.7 kB 52.2 kB +1.58 kB (+3.1%) Dependency
Type Base (0800a8b) Merge (8400f2a) Diff classes 12 dependencies
CachingClient EventEmitter InMemoryStorage IndexedDbStorage RealtimeHandler RemoteConfig RemoteConfigAbortSignal RestClient RetryingClient Storage StorageCache VisibilityMonitor
13 dependencies
CachingClient EventEmitter Experiment InMemoryStorage IndexedDbStorage RealtimeHandler RemoteConfig RemoteConfigAbortSignal RestClient RetryingClient Storage StorageCache VisibilityMonitor
+ ExperimentfetchConfigSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.7 kB 24.1 kB +347 B (+1.5%) size-with-ext-deps 50.2 kB 50.6 kB +347 B (+0.7%) getAllSize
Type Base (0800a8b) Merge (8400f2a) Diff size 24.3 kB 24.7 kB +347 B (+1.4%) size-with-ext-deps 50.8 kB 51.1 kB +347 B (+0.7%) getBooleanSize
Type Base (0800a8b) Merge (8400f2a) Diff size 24.2 kB 24.5 kB +347 B (+1.4%) size-with-ext-deps 50.7 kB 51.0 kB +347 B (+0.7%) getNumberSize
Type Base (0800a8b) Merge (8400f2a) Diff size 24.2 kB 24.5 kB +347 B (+1.4%) size-with-ext-deps 50.7 kB 51.0 kB +347 B (+0.7%) getRemoteConfigSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.9 kB 24.3 kB +347 B (+1.5%) size-with-ext-deps 57.3 kB 57.7 kB +347 B (+0.6%) getStringSize
Type Base (0800a8b) Merge (8400f2a) Diff size 24.2 kB 24.5 kB +347 B (+1.4%) size-with-ext-deps 50.7 kB 51.0 kB +347 B (+0.7%) getValueSize
Type Base (0800a8b) Merge (8400f2a) Diff size 24.1 kB 24.5 kB +347 B (+1.4%) size-with-ext-deps 50.6 kB 51.0 kB +347 B (+0.7%) isSupportedSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.3 kB 23.6 kB +347 B (+1.5%) size-with-ext-deps 49.7 kB 50.1 kB +347 B (+0.7%) onConfigUpdateSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.3 kB 23.6 kB +347 B (+1.5%) size-with-ext-deps 49.7 kB 50.1 kB +347 B (+0.7%) setCustomSignalsSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.6 kB 24.0 kB +347 B (+1.5%) size-with-ext-deps 50.1 kB 50.5 kB +347 B (+0.7%) setLogLevelSize
Type Base (0800a8b) Merge (8400f2a) Diff size 23.3 kB 23.6 kB +347 B (+1.5%) size-with-ext-deps 49.8 kB 50.1 kB +347 B (+0.7%)