firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Feat/google3 typings support

Open eranc-google opened this issue 6 months ago • 1 comments

This PR adds a new Rollup build configuration to the analytics and remote-config packages. This is required to generate self-contained TypeScript definition (.d.ts) files, which are necessary for consuming these modular SDKs within google3.

This change follows the process outlined in the internal guide for this migration: go/how-to-migrate-to-modular-firebase-js-sdk.

Discussion There is no public GitHub issue for this change. This work is part of an internal migration effort for Google's Chronicle SOAR UI (internal design doc: go/soar-custom-signals).

This was discussed internally with members of the Firebase team (Christina Holland), who pointed us to the migration guide that necessitates this PR.

Testing These changes are additive and only affect the build configuration; they do not modify any of the core library source code in /src. As such, they should not impact existing tests.

The project builds successfully (yarn build) with these changes included. The ultimate test for this change will be its consumption by the internal google3 build process after the generated artifacts are imported.

API Changes This PR introduces no changes to the public API. All modifications are confined to devDependencies in package.json and the addition of a new, non-default build step in rollup.config.js.

eranc-google avatar Jun 08 '25 13:06 eranc-google

🦋 Changeset detected

Latest commit: 30e4182379bb2c71cd5bdb429e666c16aac7f196

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@firebase/remote-config Patch
@firebase/analytics Patch
firebase Patch
@firebase/remote-config-compat Patch
@firebase/analytics-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 08 '25 13:06 changeset-bot[bot]

One last thing, to fix the formatting check just run yarn format (I think this just converts the double newlines to single in the remote-config/rollup.config.js)

hsubox76 avatar Jun 17 '25 18:06 hsubox76