firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Add node engines fields specifying a minimum of 18

Open hsubox76 opened this issue 1 year ago • 3 comments

Update all appropriate package.json files in the repo to reflect a minimum Node engines version of 18.

Exceptions:

  • Unpublished packages that only serve as entry points. e.g. auth/cordova, or firebase/compat/storage (the actual published package is @firebase/storage-compat).
  • Types packages - FYI these are leftover from compat - all modular code should be using types within their own package.
  • Auth demo apps - these are demo apps for auth testing and should be maintained by auth to the specification they want them at
  • Packages that shouldn't be used in Node at all (Analytics, Installations, Messaging, Performance, Remote Config, Webchannel-wrapper)
  • The template packages

Notes:

  • Internal packages like component, logger, and util should be platform agnostic, but this enables us to introduce any new APIs (e.g., new cryptography API) that old versions of Node don't support, if we need to in the future
  • 18 isn't necessarily the exact minimum for many of our internal tools, many of which can handle much older versions of Node, but our CI runs on 18 anyway.

See https://docs.google.com/spreadsheets/d/1TpQleZQiw1AW_E_CQE12mfW0cRNLvwIB03hDsfop7f8/edit?gid=0&resourcekey=0-k7oyij2BtGpazx4_2cexuA#gid=0 (internal link) for a breakdown of exactly which packages were included or excluded and some notes as to why.

hsubox76 avatar Aug 23 '24 21:08 hsubox76

⚠️ No Changeset found

Latest commit: 40481b5b1c474743242aa6b9e332419ee2426a74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 23 '24 21:08 changeset-bot[bot]

Size Report 1

Affected Products

No changes between base commit (5594ebc) and merge commit (503e462).

Test Logs

google-oss-bot avatar Aug 23 '24 22:08 google-oss-bot

Size Analysis Report 1

Affected Products

No changes between base commit (5594ebc) and merge commit (503e462).

Test Logs

google-oss-bot avatar Aug 23 '24 22:08 google-oss-bot