firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard
verified publisher icon firebase

Fix FirebaseServerApp Typescript exactOptionalPropertyTypes error

Open DellaBitta opened this issue 1 year ago • 4 comments

Discussion

This change fixes a TypeScript compilation error.

The FirebaseServerAppSettings.name field inherited from FirebaseAppSettings but the type was redefined from string to undefined. This redefinition would cause a TypeScript compliation error if exactOptionalPropertyTypes was set true in packages/app/tsconfig.json.

This change now uses omit< , > to strip the name field from the FirebaseServerAppSettings declaration, where FirebaseAppSettings is extended.

Fixes #8336

Testing

  • Local build with the TypeScript exactOptionalPropertyTypes setting defined as true.
  • CI

DellaBitta avatar Jun 27 '24 14:06 DellaBitta

🦋 Changeset detected

Latest commit: ad7a9ad7c57f8d63863d3fc45e95afa9fff88b3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
firebase Patch
@firebase/app Patch
@firebase/app-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 27 '24 14:06 changeset-bot[bot]

Size Report 1

Affected Products

No changes between base commit (ed1c993) and merge commit (0b145e1).

Test Logs

google-oss-bot avatar Jun 27 '24 14:06 google-oss-bot

Size Analysis Report 1

Affected Products

No changes between base commit (ed1c993) and merge commit (0b145e1).

Test Logs

google-oss-bot avatar Jun 27 '24 15:06 google-oss-bot

Changeset File Check :white_check_mark:

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

github-actions[bot] avatar Jun 28 '24 13:06 github-actions[bot]