firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Upgrade firebase-admin and google/cloud-firestore in rules-unit-testing yarn lock

Open dlarocque opened this issue 1 year ago • 7 comments

This change is automatically done when running yarn test in the repo. We should probably check it into the repo?

The version of google-cloud/firestore in the rules-unit-testing/functions/yarn.lock was listed as '6.6.0', when it was actually pulling '6.8.0'. This change upgrades the listed version to be the real version.

dlarocque avatar Jun 05 '24 16:06 dlarocque

🦋 Changeset detected

Latest commit: ae841d6636db9c4279877783bd7c5c15d461a2e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 05 '24 16:06 changeset-bot[bot]

Changeset File Check :white_check_mark:

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

github-actions[bot] avatar Jun 05 '24 16:06 github-actions[bot]

Size Report 1

Affected Products

No changes between base commit (a90255a) and merge commit (544095e).

Test Logs

google-oss-bot avatar Jun 05 '24 16:06 google-oss-bot

Size Analysis Report 1

Affected Products

No changes between base commit (a90255a) and merge commit (544095e).

Test Logs

google-oss-bot avatar Jun 05 '24 17:06 google-oss-bot

This looks like it changes the admin SDK version, too. If that's a dev dependency then that's fine, but if not then we should add a changeset to this PR.

DellaBitta avatar Jun 05 '24 18:06 DellaBitta

This looks like it changes the admin SDK version, too. If that's a dev dependency then that's fine, but if not then we should add a changeset to this PR.

Looks like it isn't a dev dependency, so I added a changeset 👍

dlarocque avatar Jun 05 '24 18:06 dlarocque

It looks like there's a ghost entry in the toc in master that's causing our doc change check to fail. #8300 should fix

Edit: this has been fixed, CI is good now

dlarocque avatar Jun 05 '24 19:06 dlarocque