Spelling

[jsoref]

Discussion

#8279

Testing

• Make sure all existing tests in the repository pass after your change. -- They do (although, many of them required fixes in #8275 for me to validate)
• If you fixed a bug or added a feature, add a new test to cover your code. -- This can be done by applying a variant of https://github.com/jsoref/firebase-js-sdk/commit/spell-check, but I'd prefer to leave that outside the scope of this PR

API Changes

I believe there's one API change included: https://github.com/jsoref/firebase-js-sdk/commit/10eacaec7a576fc1dea6110af813292c362586e8

I've included it in the hopes that it isn't an API and, thus, can be changed. If it's an API and can't be changed, it's trivial for me to drop it (just as I'm more than happy to drop any other changes).

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 8433b909a867d97401b7d87d0ec0f56bc9c1979a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@firebase/installations-compat	Patch
@firebase/remote-config-compat	Patch
@firebase/installations-types	Patch
@firebase/remote-config-types	Patch
@firebase/performance-compat	Patch
@firebase/rules-unit-testing	Patch
@firebase/webchannel-wrapper	Patch
@firebase/performance-types	Patch
@firebase/analytics-compat	Patch
@firebase/app-check-compat	Patch
@firebase/firestore-compat	Patch
@firebase/functions-compat	Patch
@firebase/messaging-compat	Patch
@firebase/database-compat	Patch
@firebase/database-types	Patch
@firebase/storage-compat	Patch
@firebase/installations	Patch
@firebase/remote-config	Patch
@firebase/auth-compat	Patch
@firebase/performance	Patch
@firebase/app-compat	Patch
@firebase/analytics	Patch
@firebase/app-check	Patch
@firebase/component	Patch
@firebase/firestore	Patch
@firebase/functions	Patch
@firebase/messaging	Patch
@firebase/database	Patch
firebase	Patch
@firebase/template	Patch
@firebase/vertexai-preview	Patch
@firebase/storage	Patch
@firebase/logger	Patch
@firebase/auth	Patch
@firebase/util	Patch
@firebase/app	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jsoref]

The changes are all manual (more or less), and anything that isn't a simple replacement is very manual (especially things like neither).

Splitting is more or less possible -- it's easy for me to group commits together, or split by directory. It's fairly painful for me to split by part of speech if a word is used in more than one part of speech (and gets prohibitive as the word count grows -- it's error prone, and as a human, I make mistakes like everyone else), but it's certainly not a problem for me to peel off individual commits or group commits together into separate PRs -- I just need direction. For smaller repositories, I can split by "code" vs "comment" -- although I really don't like to do it as it isn't particularly safe -- it's much cleaner to split by directory or possibly file extension.

The only thing that's fully automated is identifying potential problems. I can certainly run the tooling on any repository if people are interested. Sometimes I rely on Google Sheets for word corrections, although of late, I've just been using Google Chrome suggestions.

[jsoref]

Do I need to worry about the changeset bot?

Note that https://github.com/firebase/firebase-js-sdk/actions/runs/9639724064/job/26582355096?pr=8280 is failing (I can't remember the state of this, I split most other CI failures into other PRs...)

[jsoref]

@DellaBitta: I can't get yarn to cooperate

jsoref@jsoref-mbp firebase-js-sdk % node --version
v20.11.0
jsoref@jsoref-mbp firebase-js-sdk % yarn
➤ YN0000: · Yarn 4.2.1
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: closure-net@https://github.com/google/closure-net.git#commit=0412666e8f29b8ae69decb1fdc7ead635a5cf43e: Manifest not found
    at AE.find (/Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:140:120021)
    at async /Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:520:11979
    at async Object.xZe (/Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:140:53847)
    at async I2.resolve (/Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:520:11940)
    at async Dd.resolve (/Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:141:1451)
    at async Dd.resolve (/Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:141:1451)
    at async /Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:210:7249
    at async Ky (/Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:140:53910)
    at async ne (/Users/jsoref/.yarn/releases/yarn-4.2.1.cjs:210:7231)
    at async Promise.allSettled (index 1)
➤ YN0000: └ Completed in 0s 873ms
➤ YN0000: · Failed with errors in 0s 883ms

I've given permission to push into my branch...

[DellaBitta]

Done! Waiting for CI to execute now.