firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard
verified publisher icon firebase

Generate dts rollups for auth webextension and cordova

Open dlarocque opened this issue 1 year ago • 3 comments

Fixes #8222

auth web-extension and cordova packages had typings that were not rolled up by dts, which caused some compilation errors to arise in the typings files.

The API extractor tool does not work with package names with more than one /, so we have to change the package names for these from @firebase/auth-web-extension -> @firebase/auth-web-extension, and @firebase/auth/cordova -> @firebase/auth-cordova. This does not affect the way we import these packages, since that's done through the firebase package, and the typings are resolved based on the directory name (e.g. ./auth/cordova) rather than the package name.

Note: There are a lot of warnings coming from the API extractor because it is not able to resolve @link's, since these packages don't actually export what their entrypoints export. I currently don't have any ideas on how to fix this. Example: firebase-js-sdk/packages/auth/dist/web-extension-esm2017/index.web-extension.d.ts:3311:5 - (ae-unresolved-link) The @link reference could not be resolved: The package "@firebase/auth-web-extension" does not have an export "ProviderId"

dlarocque avatar May 16 '24 15:05 dlarocque

🦋 Changeset detected

Latest commit: a4efa7a87a04c11de6ec228209f2e67ce8a0ac03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 16 '24 15:05 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/auth-cordova

    TypeBase (3883133)Merge (957db22)Diff
    browser?210 kB? (?)
    module?210 kB? (?)

  • @firebase/auth-web-extension

    TypeBase (3883133)Merge (957db22)Diff
    browser?137 kB? (?)
    main?152 kB? (?)
    module?137 kB? (?)

Test Logs

google-oss-bot avatar May 16 '24 15:05 google-oss-bot

Size Analysis Report 1

Affected Products

No changes between base commit (3883133) and merge commit (957db22).

Test Logs

google-oss-bot avatar May 16 '24 16:05 google-oss-bot