firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard
verified publisher icon firebase

Add a new VertexAI error type

Open dlarocque opened this issue 1 year ago • 3 comments

  • Added VertexAIError so that users can instanceof the errors from the VertexAI SDK.
  • Added optional HTTP fields to errors (status, statusText, errorDetails) (mirroring https://github.com/google-gemini/generative-ai-js/commit/111e970a645f8bd01aa023cf0de53964c9d40342)
  • Moved away from using ErrorFactory towards our new error type
  • Added a generic error code VertexAIErrorCode.ERROR to align with the generic error in the Google AI SDK GoogleGenerativeAIError

Testing

I tested this in a React application in Chrome and Safari, and in a Node project. instanceof and the stack trace works in these environments.

Error output in different environments

Safari

image

Chrome

image

Node

VertexAIError [FirebaseError]: Error fetching from https://firebaseml.googleapis.com/v2beta/projects/<omitted>/locations/us-central1/publishers/google/models/gemini-1.5-pro-preview-0409:generateContent: [400 Bad Request] Invalid value at 'contents[0].parts[0].text' (TYPE_STRING), 1 [{"@type":"type.googleapis.com/google.rpc.BadRequest","fieldViolations":[{"field":"contents[0].parts[0].text","description":"Invalid value at 'contents[0].parts[0].text' (TYPE_STRING), 1"}]}]
    at makeRequest (/Users/dlarocque/workspace/firebase/firebase-js-sdk/packages/vertexai/dist/index.cjs.js:408:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async generateContent (/Users/dlarocque/workspace/firebase/firebase-js-sdk/packages/vertexai/dist/index.cjs.js:747:22)
    at async run (/Users/dlarocque/workspace/test/vertex-gcs-filedata/index.js:19:20) {
  code: 'fetch-error',
  customData: undefined,
  status: 400,
  statusText: 'Bad Request',
  errorDetails: [
    {
      '@type': 'type.googleapis.com/google.rpc.BadRequest',
      fieldViolations: [
        {
          field: 'contents[0].parts[0].text',
          description: "Invalid value at 'contents[0].parts[0].text' (TYPE_STRING), 1"
        }
      ]
    }
  ],
  toString: [Function (anonymous)]
}

dlarocque avatar May 09 '24 20:05 dlarocque

🦋 Changeset detected

Latest commit: 93588d78f5ea410944bcfa8abab7ecfbfd8384dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai-preview Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 09 '24 20:05 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/vertexai-preview

    TypeBase (8360014)Merge (b72a4db)Diff
    browser25.2 kB25.4 kB+248 B (+1.0%)
    main25.8 kB26.0 kB+269 B (+1.0%)
    module25.2 kB25.4 kB+248 B (+1.0%)

  • firebase

    TypeBase (8360014)Merge (b72a4db)Diff
    firebase-vertexai-preview.js19.3 kB19.6 kB+309 B (+1.6%)

Test Logs

google-oss-bot avatar May 09 '24 20:05 google-oss-bot

Size Analysis Report 1

Affected Products

  • @firebase/vertexai-preview

    • BlockReason

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.94 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • ChatSession

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size14.4 kB14.1 kB-312 B (-2.2%)
      size-with-ext-deps32.8 kB32.5 kB-308 B (-0.9%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      classes

      ChatSession
RequestUrl
VertexAIService

      ChatSession
RequestUrl
VertexAIError
VertexAIService

      + VertexAIError
      variables

      27 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      25 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      - ERRORS

      - ERROR_FACTORY

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      FirebaseError

      + FirebaseError

      - ErrorFactory

    • FinishReason

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.94 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • FunctionCallingMode

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.95 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • FunctionDeclarationSchemaType

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.68 kB2.96 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • GenerativeModel

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size16.7 kB16.6 kB-60 B (-0.4%)
      size-with-ext-deps35.1 kB35.0 kB-56 B (-0.2%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      classes

      ChatSession
GenerativeModel
RequestUrl
VertexAIService

      ChatSession
GenerativeModel
RequestUrl
VertexAIError
VertexAIService

      + VertexAIError
      variables

      27 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      25 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      - ERRORS

      - ERROR_FACTORY

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      FirebaseError

      + FirebaseError

      - ErrorFactory

    • HarmBlockMethod

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.95 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • HarmBlockThreshold

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.95 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • HarmCategory

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.94 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • HarmProbability

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.95 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • HarmSeverity

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.67 kB2.94 kB-724 B (-19.7%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • POSSIBLE_ROLES

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.71 kB2.99 kB-724 B (-19.5%)
      size-with-ext-deps21.4 kB20.7 kB-703 B (-3.3%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      16 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
POSSIBLE_ROLES
Task
VERTEX_TYPE
name
version

      15 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
POSSIBLE_ROLES
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      - ErrorFactory

    • VertexAIError

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size?3.27 kB? (?)
      size-with-ext-deps?21.0 kB? (?)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      functions?

      registerVertex
      		?
      classes?

      VertexAIError
VertexAIService
      		?
      variables?

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version
      		?
      enums??

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/app?

      _registerComponent
registerVersion
      		?
      @firebase/component?

      Component
      		?
      @firebase/util?

      FirebaseError
      		?

    • getGenerativeModel

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size16.7 kB16.8 kB+22 B (+0.1%)
      size-with-ext-deps35.2 kB35.2 kB+26 B (+0.1%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      classes

      ChatSession
GenerativeModel
RequestUrl
VertexAIService

      ChatSession
GenerativeModel
RequestUrl
VertexAIError
VertexAIService

      + VertexAIError
      variables

      27 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      25 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      - ERRORS

      - ERROR_FACTORY

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory

      FirebaseError

      + FirebaseError

      - ErrorFactory

    • getVertexAI

      Size

      TypeBase (8360014)Merge (b72a4db)Diff
      size3.84 kB3.12 kB-719 B (-18.7%)
      size-with-ext-deps28.8 kB28.1 kB-703 B (-2.4%)

      Dependency

      TypeBase (8360014)Merge (b72a4db)Diff
      variables

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      - ERRORS

      External Dependency

      ModuleBase (8360014)Merge (b72a4db)Diff
      @firebase/util

      ErrorFactory
getModularInstance

      getModularInstance

      - ErrorFactory

Test Logs

google-oss-bot avatar May 09 '24 20:05 google-oss-bot