firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Fix analytics consent updating (#8210)

Open megamisan opened this issue 9 months ago • 2 comments

  • Fix call to consent update after integrating rest operator for gtag wrapper.

Closes #8210

megamisan avatar Apr 27 '24 18:04 megamisan

⚠️ No Changeset found

Latest commit: bbaec7757cbe4709a97e86249043f4c22cbe8cf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 27 '24 18:04 changeset-bot[bot]

After testing the patch locally, I got the expected result. Tag Assistant screenshot

megamisan avatar Apr 27 '24 18:04 megamisan

Hi @megamisan,

Thanks for proposing this fix. We went a different route to fix the issue by updating the wrappedGtagFunction implementation, and keeping the invocation the same. Please see #8243.

I'm going to close this PR for now because I beleive it's not required anymore. Let me know if I closed it in error. Thanks again!

DellaBitta avatar May 15 '24 18:05 DellaBitta