firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Firestore: Factor out logic that extracts paths from package.json in rollup scripts

Open dconeybe opened this issue 1 year ago • 3 comments

This PR adds the function getPackageJsonExportPaths() to rollup.shared.js so that the rollup scripts can access the "exports" paths from package.json in a consistent way, rather than the random bespoke ways. This should help to improve the readability of the rollup scripts.

Work In Progress

This PR is a work-in-progress. As of Jan 22, 2024, work on this PR has been de-prioritized but I'm leaving it here so it can be picked up in the future. Googlers see b/302682954 for details.

dconeybe avatar Jan 16 '24 19:01 dconeybe

⚠️ No Changeset found

Latest commit: bddda9d2e8c9dee8c0168aa002c1c13b2cf96a91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 16 '24 19:01 changeset-bot[bot]

Size Report 1

Affected Products

No changes between base commit (991fa27) and merge commit (52f3a0b).

Test Logs

google-oss-bot avatar Jan 16 '24 19:01 google-oss-bot

Size Analysis Report 1

Affected Products

No changes between base commit (991fa27) and merge commit (52f3a0b).

Test Logs

google-oss-bot avatar Jan 16 '24 20:01 google-oss-bot