Firestore: Deduplicate some repeated logic in OfflineComponentProvider
This PR simply deduplicates some logic in the OfflineComponentProvider class that starts and stops the schedulers (the gc scheduler and index backfiller scheduler). This small cleanup will be built upon in the upcoming PR that makes the index backfiller scheduler tree-shakeable (https://github.com/firebase/firebase-js-sdk/pull/7902).
Work In Progress
This PR is a work-in-progress. As of Jan 22, 2024, work on this PR has been de-prioritized but I'm leaving it here so it can be picked up in the future. Googlers see b/293449522 for details.
🦋 Changeset detected
Latest commit: b103153e7af81ccc65cda2231060baa3fe1c8f7e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Size Report 1
Affected Products
@firebase/firestoreType Base (49c7903) Merge (fdf4084) Diff browser 375 kB 375 kB -219 B (-0.1%) esm5 360 kB 360 kB -169 B (-0.0%) main 577 kB 577 kB -59 B (-0.0%) module 375 kB 375 kB -219 B (-0.1%) react-native 375 kB 375 kB -219 B (-0.1%) bundleType Base (49c7903) Merge (fdf4084) Diff firestore (CSI Auto Indexing Disable and Delete) 268 kB 268 kB -83 B (-0.0%) firestore (CSI Auto Indexing Enable) 268 kB 268 kB -83 B (-0.0%) firestore (Persistence) 303 kB 302 kB -219 B (-0.1%) firestore (Read Write w Persistence) 321 kB 321 kB -219 B (-0.1%) firebaseType Base (49c7903) Merge (fdf4084) Diff firebase-compat.js 779 kB 779 kB -219 B (-0.0%) firebase-firestore-compat.js 341 kB 341 kB -219 B (-0.1%) firebase-firestore.js 434 kB 434 kB -219 B (-0.1%)
Test Logs
Size Analysis Report 1
Affected Products
@firebase/firestoreenableIndexedDbPersistenceSize
Type Base (49c7903) Merge (fdf4084) Diff size 186 kB 186 kB -83 B (-0.0%) size-with-ext-deps 258 kB 258 kB -83 B (-0.0%) enableMultiTabIndexedDbPersistenceSize
Type Base (49c7903) Merge (fdf4084) Diff size 222 kB 222 kB -219 B (-0.1%) size-with-ext-deps 294 kB 294 kB -219 B (-0.1%) persistentLocalCacheSize
Type Base (49c7903) Merge (fdf4084) Diff size 183 kB 183 kB -83 B (-0.0%) size-with-ext-deps 255 kB 255 kB -83 B (-0.0%) persistentMultipleTabManagerSize
Type Base (49c7903) Merge (fdf4084) Diff size 219 kB 218 kB -219 B (-0.1%) size-with-ext-deps 291 kB 291 kB -219 B (-0.1%) persistentSingleTabManagerSize
Type Base (49c7903) Merge (fdf4084) Diff size 183 kB 183 kB -83 B (-0.0%) size-with-ext-deps 255 kB 255 kB -83 B (-0.0%)
Test Logs
Changeset File Check :warning:
- Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/firestore%0A%0A Make sure this was intentional.