firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Firestore: Deduplicate some repeated logic in OfflineComponentProvider

Open dconeybe opened this issue 1 year ago • 4 comments

This PR simply deduplicates some logic in the OfflineComponentProvider class that starts and stops the schedulers (the gc scheduler and index backfiller scheduler). This small cleanup will be built upon in the upcoming PR that makes the index backfiller scheduler tree-shakeable (https://github.com/firebase/firebase-js-sdk/pull/7902).

Work In Progress

This PR is a work-in-progress. As of Jan 22, 2024, work on this PR has been de-prioritized but I'm leaving it here so it can be picked up in the future. Googlers see b/293449522 for details.

dconeybe avatar Jan 16 '24 04:01 dconeybe

🦋 Changeset detected

Latest commit: b103153e7af81ccc65cda2231060baa3fe1c8f7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 16 '24 04:01 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (49c7903)Merge (fdf4084)Diff
    browser375 kB375 kB-219 B (-0.1%)
    esm5360 kB360 kB-169 B (-0.0%)
    main577 kB577 kB-59 B (-0.0%)
    module375 kB375 kB-219 B (-0.1%)
    react-native375 kB375 kB-219 B (-0.1%)
  • bundle

    TypeBase (49c7903)Merge (fdf4084)Diff
    firestore (CSI Auto Indexing Disable and Delete)268 kB268 kB-83 B (-0.0%)
    firestore (CSI Auto Indexing Enable)268 kB268 kB-83 B (-0.0%)
    firestore (Persistence)303 kB302 kB-219 B (-0.1%)
    firestore (Read Write w Persistence)321 kB321 kB-219 B (-0.1%)
  • firebase

    TypeBase (49c7903)Merge (fdf4084)Diff
    firebase-compat.js779 kB779 kB-219 B (-0.0%)
    firebase-firestore-compat.js341 kB341 kB-219 B (-0.1%)
    firebase-firestore.js434 kB434 kB-219 B (-0.1%)

Test Logs

google-oss-bot avatar Jan 16 '24 04:01 google-oss-bot

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • enableIndexedDbPersistence

      Size

      TypeBase (49c7903)Merge (fdf4084)Diff
      size186 kB186 kB-83 B (-0.0%)
      size-with-ext-deps258 kB258 kB-83 B (-0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (49c7903)Merge (fdf4084)Diff
      size222 kB222 kB-219 B (-0.1%)
      size-with-ext-deps294 kB294 kB-219 B (-0.1%)
    • persistentLocalCache

      Size

      TypeBase (49c7903)Merge (fdf4084)Diff
      size183 kB183 kB-83 B (-0.0%)
      size-with-ext-deps255 kB255 kB-83 B (-0.0%)
    • persistentMultipleTabManager

      Size

      TypeBase (49c7903)Merge (fdf4084)Diff
      size219 kB218 kB-219 B (-0.1%)
      size-with-ext-deps291 kB291 kB-219 B (-0.1%)
    • persistentSingleTabManager

      Size

      TypeBase (49c7903)Merge (fdf4084)Diff
      size183 kB183 kB-83 B (-0.0%)
      size-with-ext-deps255 kB255 kB-83 B (-0.0%)

Test Logs

google-oss-bot avatar Jan 16 '24 05:01 google-oss-bot

Changeset File Check :warning:

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/firestore%0A%0A Make sure this was intentional.

github-actions[bot] avatar Jan 19 '24 17:01 github-actions[bot]