firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Fix/Improve jsdoc for withSecurityRulesDisabled

Open palmerusaf opened this issue 3 years ago • 6 comments

fix comment to jsdoc so it gets picked up by the api extractor change description wording slightly to add clarity since method differs from the other context methods add example of use case add dash after @param

This PR is related to issue #6668. Link

palmerusaf avatar Oct 11 '22 06:10 palmerusaf

⚠️ No Changeset found

Latest commit: 9b05fd80182a4740a584ec9b69b27e7682563cfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 11 '22 06:10 changeset-bot[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 11 '22 06:10 google-cla[bot]

FYI, after this is merged, someone will have to manually run the docgen script and publish it to devsite for the changes to take place, will try to keep it on the todo list.

hsubox76 avatar Oct 12 '22 17:10 hsubox76

Oops, you probably want to run yarn format and push again. Looks like just a small whitespace difference.

hsubox76 avatar Oct 12 '22 17:10 hsubox76

@hsubox76 yarn formatted and re-pushed.

palmerusaf avatar Oct 12 '22 18:10 palmerusaf

This never was merged. 2 years later, still a problem.

BuyMyBeard avatar Jul 31 '24 19:07 BuyMyBeard