export count query

[milaGGL]

Withholding this PR till the count query is ready to be released.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 88d026653c3fe3017a6c7708c1ef5f6f310b0cab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Minor
firebase	Minor
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

• @firebase/firestore

  Type	Base (c6ba6fc)	Merge (5d2ff5a)	Diff
  browser	264 kB	265 kB	+1.42 kB (+0.5%)
  esm5	327 kB	329 kB	+2.00 kB (+0.6%)
  main	527 kB	530 kB	+2.99 kB (+0.6%)
  module	264 kB	265 kB	+1.42 kB (+0.5%)
  react-native	264 kB	265 kB	+1.42 kB (+0.5%)

• @firebase/firestore-lite

  Type	Base (c6ba6fc)	Merge (5d2ff5a)	Diff
  browser	80.9 kB	82.1 kB	+1.15 kB (+1.4%)
  esm5	96.8 kB	98.3 kB	+1.46 kB (+1.5%)
  main	136 kB	139 kB	+2.38 kB (+1.7%)
  module	80.9 kB	82.1 kB	+1.15 kB (+1.4%)
  react-native	81.1 kB	82.3 kB	+1.17 kB (+1.4%)

• firebase

  Type	Base (c6ba6fc)	Merge (5d2ff5a)	Diff
  firebase-firestore-lite.js	86.3 kB	87.7 kB	+1.43 kB (+1.7%)
  firebase-firestore.js	311 kB	313 kB	+1.42 kB (+0.5%)

Test Logs

• Base (c6ba6fc): https://github.com/firebase/firebase-js-sdk/actions/runs/3129881581
• Merge (5d2ff5a): https://github.com/firebase/firebase-js-sdk/actions/runs/3139010543

1. https://storage.googleapis.com/firebase-sdk-metric-reports/bkbFoUWhFz.html

[google-oss-bot]

Size Analysis Report ¹

This report is too large (1,419,993 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

• Merge (5d2ff5a): https://github.com/firebase/firebase-js-sdk/actions/runs/3139010543

1. https://storage.googleapis.com/firebase-sdk-metric-reports/IIiYUx9kUI.html

[dconeybe]

nit: Spelling error in this PR's title: "qury"

[ehsannas]

@milaGGL Please rebase this PR against master

[dconeybe]

Here's another problem: When I ran yarn build it produced this error:

Error: Circular dependency: src/lite-api/aggregate.ts -> src/core/count_query_runner.ts -> src/lite-api/aggregate.ts

This need to be fixed too.

[dconeybe]

I've added the do-not-merge label to make sure we don't merge until we get the green light to release count.

[dconeybe]

Here are some things that would be great to get into a follow-on PR, thanks!

Thanks for the suggestions! I was the one who wrote these doc comments so I'll make the follow-up changes. I'll be tracking this work in b/250612059.

[egilmorez]

Sounds good, thanks Denver!

On Mon, Oct 3, 2022 at 9:50 AM Denver Coneybeare @.***> wrote:

Here are some things that would be great to get into a follow-on PR, thanks!

Thanks for the suggestions! I was the one who wrote these doc comments so I'll make the follow-up changes. I'll be tracking this work in b/250612059 https://buganizer.corp.google.com/250612059.

— Reply to this email directly, view it on GitHub https://github.com/firebase/firebase-js-sdk/pull/6608#issuecomment-1265744896, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKJWAYG4QZFBD4E4VCBXC3WBMFF5ANCNFSM6AAAAAAQOQQTQI . You are receiving this because your review was requested.Message ID: @.***>