firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Add overloads for query and deprecate existing query overload that supports implicit ANDs of filters.

Open MarkDuckworth opened this issue 2 years ago • 1 comments

Add overloads for query and deprecate existing query overload that supports implicit ANDs of filters.

Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in an issue so that we can discuss it together.

MarkDuckworth avatar Aug 26 '22 17:08 MarkDuckworth

⚠️ No Changeset found

Latest commit: 77afd209287063c2809f0c11efab40bb33d5c7ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 26 '22 17:08 changeset-bot[bot]

We decided not to move forward with this change to the public API.

MarkDuckworth avatar Oct 25 '22 17:10 MarkDuckworth