firebase-js-sdk
firebase-js-sdk copied to clipboard
Making public API changes to ensure that only QueryFilterConstraints can be passed to or(...) and and(...).
Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:
Discussion
- Read the contribution guidelines (CONTRIBUTING.md).
- If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.
Testing
- Make sure all existing tests in the repository pass after your change.
- If you fixed a bug or added a feature, add a new test to cover your code.
API Changes
- At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in an issue so that we can discuss it together.
⚠️ No Changeset found
Latest commit: b5a8fba19bdf8d553c70296908a1308290bacda8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Size Report 1
Affected Products
@firebase/firestore
Type Base (2a20810) Merge (2cac942) Diff browser 269 kB 269 kB +762 B (+0.3%) esm5 333 kB 334 kB +869 B (+0.3%) main 538 kB 539 kB +1.73 kB (+0.3%) module 269 kB 269 kB +762 B (+0.3%) react-native 269 kB 270 kB +762 B (+0.3%) @firebase/firestore-lite
Type Base (2a20810) Merge (2cac942) Diff browser 82.4 kB 83.9 kB +1.55 kB (+1.9%) esm5 98.6 kB 101 kB +1.98 kB (+2.0%) main 139 kB 142 kB +3.58 kB (+2.6%) module 82.4 kB 83.9 kB +1.55 kB (+1.9%) react-native 82.6 kB 84.1 kB +1.55 kB (+1.9%) bundle
Type Base (2a20810) Merge (2cac942) Diff firestore (Query Cursors) 211 kB 212 kB +233 B (+0.1%) firestore (Query) 213 kB 213 kB +161 B (+0.1%) firestore-lite (Query Cursors) 73.3 kB 73.6 kB +233 B (+0.3%) firestore-lite (Query) 72.7 kB 72.9 kB +171 B (+0.2%) firebase
Type Base (2a20810) Merge (2cac942) Diff firebase-compat.js 742 kB 742 kB +410 B (+0.1%) firebase-firestore-compat.js 317 kB 317 kB +410 B (+0.1%) firebase-firestore-lite.js 87.7 kB 89.3 kB +1.55 kB (+1.8%) firebase-firestore.js 316 kB 317 kB +762 B (+0.2%)
Test Logs