firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard
verified publisher icon firebase

Refactor core/target.ts, extracting classes Bound, OrderBy, and Filter

Open MarkDuckworth opened this issue 3 years ago • 3 comments

Refactor core/target.ts, extracting classes Bound, OrderBy, and Filter (+subclasses)

Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in an issue so that we can discuss it together.

MarkDuckworth avatar Aug 24 '22 16:08 MarkDuckworth

⚠️ No Changeset found

Latest commit: 960d1585e1cf76cf5f7c2258478f7d292d6d61d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 24 '22 16:08 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/firestore-lite

    TypeBase (c15333a)Merge (f23a897)Diff
    esm598.6 kB98.6 kB+4 B (+0.0%)

  • firebase

    TypeBase (c15333a)Merge (f23a897)Diff
    firebase-compat.js742 kB742 kB-36 B (-0.0%)
    firebase-firestore-compat.js317 kB317 kB-36 B (-0.0%)

Test Logs

google-oss-bot avatar Aug 24 '22 17:08 google-oss-bot

Size Analysis Report 1

This report is too large (243,120 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

google-oss-bot avatar Aug 24 '22 17:08 google-oss-bot