firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

OR Queries public API and integration tests

Open MarkDuckworth opened this issue 3 years ago • 3 comments

Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in an issue so that we can discuss it together.

MarkDuckworth avatar Aug 23 '22 23:08 MarkDuckworth

⚠️ No Changeset found

Latest commit: 350113596070dfbd21d4979152747d4254312d55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 23 '22 23:08 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (186fd92)Merge (845bec0)Diff
    browser268 kB268 kB+114 B (+0.0%)
    esm5333 kB333 kB+129 B (+0.0%)
    main535 kB535 kB+312 B (+0.1%)
    module268 kB268 kB+114 B (+0.0%)
    react-native269 kB269 kB+114 B (+0.0%)
  • @firebase/firestore-lite

    TypeBase (186fd92)Merge (845bec0)Diff
    browser82.1 kB82.1 kB-18 B (-0.0%)
    esm598.3 kB98.3 kB-18 B (-0.0%)
    main138 kB138 kB-18 B (-0.0%)
    module82.1 kB82.1 kB-18 B (-0.0%)
    react-native82.3 kB82.3 kB-18 B (-0.0%)
  • bundle

    TypeBase (186fd92)Merge (845bec0)Diff
    firestore (Persistence)278 kB278 kB+114 B (+0.0%)
    firestore (Query Cursors)213 kB213 kB+114 B (+0.1%)
    firestore (Query)214 kB214 kB+114 B (+0.1%)
    firestore (Read data once)202 kB202 kB+114 B (+0.1%)
    firestore (Realtime updates)204 kB205 kB+114 B (+0.1%)
    firestore (Transaction)186 kB186 kB+132 B (+0.1%)
    firestore (Write data)186 kB186 kB+132 B (+0.1%)
    firestore-lite (Query Cursors)73.2 kB73.2 kB-18 B (-0.0%)
    firestore-lite (Query)72.6 kB72.6 kB-18 B (-0.0%)
  • firebase

    TypeBase (186fd92)Merge (845bec0)Diff
    firebase-compat.js798 kB798 kB+88 B (+0.0%)
    firebase-firestore-compat.js318 kB318 kB+88 B (+0.0%)
    firebase-firestore-lite.js270 kB270 kB-119 B (-0.0%)
    firebase-firestore.js864 kB864 kB-425 B (-0.0%)

Test Logs

google-oss-bot avatar Aug 24 '22 00:08 google-oss-bot

Size Analysis Report 1

This report is too large (104,138 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

google-oss-bot avatar Aug 24 '22 00:08 google-oss-bot