firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Markduckworth/or queries pr 4

Open MarkDuckworth opened this issue 2 years ago • 3 comments

Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in an issue so that we can discuss it together.

MarkDuckworth avatar Aug 12 '22 16:08 MarkDuckworth

⚠️ No Changeset found

Latest commit: 2ddc06880eab518ce2946eb9cc98e24e7dad6887

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 12 '22 16:08 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (bf21b93)Merge (501d7c0)Diff
    browser266 kB269 kB+2.75 kB (+1.0%)
    esm5330 kB333 kB+3.21 kB (+1.0%)
    main531 kB538 kB+6.69 kB (+1.3%)
    module266 kB269 kB+2.75 kB (+1.0%)
    react-native266 kB269 kB+2.75 kB (+1.0%)
  • bundle

    TypeBase (bf21b93)Merge (501d7c0)Diff
    firestore (Persistence)275 kB277 kB+1.96 kB (+0.7%)
    firestore (Query Cursors)211 kB211 kB+37 B (+0.0%)
    firestore (Query)212 kB213 kB+47 B (+0.0%)
    firestore (Read data once)201 kB201 kB+37 B (+0.0%)
    firestore (Realtime updates)203 kB203 kB+37 B (+0.0%)
    firestore (Transaction)184 kB184 kB+55 B (+0.0%)
    firestore (Write data)184 kB184 kB+55 B (+0.0%)
  • firebase

    TypeBase (bf21b93)Merge (501d7c0)Diff
    firebase-compat.js740 kB742 kB+1.89 kB (+0.3%)
    firebase-firestore-compat.js315 kB317 kB+1.89 kB (+0.6%)
    firebase-firestore.js313 kB316 kB+2.75 kB (+0.9%)

Test Logs

google-oss-bot avatar Aug 12 '22 16:08 google-oss-bot

Size Analysis Report 1

This report is too large (604,118 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

google-oss-bot avatar Aug 12 '22 16:08 google-oss-bot