firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

upgrade @firebase/polyfill core-js

Open mhDuke opened this issue 2 years ago • 1 comments

npm WARN deprecated [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues.

Please, upgrade your dependencies to >=3.23.3 of core-js.

mhDuke avatar Aug 04 '22 05:08 mhDuke

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar Aug 04 '22 05:08 google-oss-bot

second this

g-30 avatar Aug 12 '22 16:08 g-30

Same issue here. Just installed firebase right now. I hope it will be resolved soon!

dorji-tshering avatar Aug 12 '22 18:08 dorji-tshering

same issue while installing the latest [email protected].

MarwanSdeek avatar Aug 16 '22 11:08 MarwanSdeek

Bump

playtinum avatar Aug 17 '22 22:08 playtinum

So the good news is that core-js code isn't used in the code for any Firebase SDK products installed through NPM. It was included in @firebase/polyfill package which is currently only bundled into the compat CDN builds (where Firebase is included using script tags, and applying only to urls that end with -compat.js). We forgot to remove it from the dependencies in package.json (which is why it's installing during yarn/npm install) but the code isn't imported into any Firebase code.

NPM users and users of the v9 CDN scripts shouldn't need to worry. I'll remove @firebase/polyfill from the dependencies and you should stop getting that warning after the next release.

As of v9 we've stopped updating @firebase/polyfill and expect users to provide their own so I'll also remove the polyfill import from the compat CDNs.

hsubox76 avatar Aug 18 '22 16:08 hsubox76