firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard
verified publisher icon firebase

Fix: set exists:false precondition for deleted docs

Open ehsannas opened this issue 3 years ago • 5 comments

ehsannas avatar Jun 01 '22 21:06 ehsannas

⚠️ No Changeset found

Latest commit: e3a55c5d704bb938395265e34c9cc3e4630c4d70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 01 '22 21:06 changeset-bot[bot]

Changeset File Check :warning:

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

github-actions[bot] avatar Jun 01 '22 21:06 github-actions[bot]

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    browser257 kB257 kB+34 B (+0.0%)
    esm5319 kB319 kB+34 B (+0.0%)
    main515 kB515 kB+83 B (+0.0%)
    module257 kB257 kB+34 B (+0.0%)
    react-native257 kB258 kB+34 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    browser80.5 kB80.5 kB+34 B (+0.0%)
    esm596.2 kB96.2 kB+34 B (+0.0%)
    main135 kB135 kB+83 B (+0.1%)
    module80.5 kB80.5 kB+34 B (+0.0%)
    react-native80.7 kB80.7 kB+34 B (+0.0%)

  • bundle

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    firestore (Transaction)181 kB181 kB+34 B (+0.0%)
    firestore-lite (Transaction)80.0 kB80.0 kB+34 B (+0.0%)

  • firebase

    TypeBase (9fddd5c)Merge (8bba1cf)Diff
    firebase-compat.js787 kB787 kB+36 B (+0.0%)
    firebase-firestore-compat.js309 kB309 kB+36 B (+0.0%)
    firebase-firestore-lite.js267 kB267 kB+105 B (+0.0%)
    firebase-firestore.js837 kB837 kB+105 B (+0.0%)

Test Logs

google-oss-bot avatar Jun 01 '22 21:06 google-oss-bot

well... that didn't go as i expected heh

ehsannas avatar Jun 01 '22 21:06 ehsannas

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • runTransaction

      Size

      TypeBase (9fddd5c)Merge (8bba1cf)Diff
      size113 kB113 kB+33 B (+0.0%)
      size-with-ext-deps174 kB174 kB+34 B (+0.0%)

Test Logs

google-oss-bot avatar Jun 01 '22 22:06 google-oss-bot

closing this in favor of https://github.com/firebase/firebase-js-sdk/pull/6550

ehsannas avatar Aug 25 '22 23:08 ehsannas