firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Migrate Storage implementation from Objective-C to Swift

Open paulb777 opened this issue 3 years ago • 2 comments

storage-swift-phase2 is a long-lived branch for migrating the Storage implementation from Objective-C to Swift.

Almost all of the changes are a straight port from Objective C to Swift. One exception is the Authorizer code implements a new GTMSessionFetcher protocol to avoid complexity around using NSInvocation from Swift required with the old protocol.

Key commits:

  • Convert Storage Task implementation to Swift (#9880)
  • Convert StorageMetadata to Swift (#9979)
  • Storage and StorageReference to Swift (#10077)
  • StorageAuthorizer to Swift (#10117)
  • Remove FirebaseStorageInternal (#10118)
  • Storage Changelog for Firebase 10 (#10215)
  • Add new throwing reference(for url:URL) API (#10216)

paulb777 avatar Jun 29 '22 17:06 paulb777

Size Report 1

Affected Products

  • FirebaseStorage

    TypeBase (161c046)Merge (90d0c26)Diff
    CocoaPods866 kB-51.5 kB-918 kB (-105.9%)

Test Logs

google-oss-bot avatar Jun 29 '22 18:06 google-oss-bot

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (6e0fda7) to 0.00% (c69584f) by ?.

    21 individual files with coverage change

    FilenameBase (6e0fda7)Merge (c69584f)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDeleteTask.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageGetDownloadURLTask.swift?0.00%?
    StorageGetMetadataTask.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageListTask.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StoragePath.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageTokenAuthorizer.swift?0.00%?
    StorageUpdateMetadataTask.swift?0.00%?
    StorageUploadTask.swift?0.00%?
    StorageUtils.swift?0.00%?

Test Logs

google-oss-bot avatar Jun 29 '22 18:06 google-oss-bot