firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

external_rules.cmake: fail fast when preparing the external projects

Open dconeybe opened this issue 3 years ago • 1 comments

This PR modifies the cmake logic that downloads and configures external projects (e.g. snappy, leveldb) so that it fails fast when the downloading and/or configuring fails. Previously, if, for example, the snappy "patch" step were to fail then cmake would happily continue on until much later things went badly, often causing difficult to diagnose errors.

This PR makes the following improvements:

  1. Adds logging about the commands that are being run so that it's easier to debug when things go poorly.
  2. Checks the result of the execute_process() cmake function calls and fails immediately if they fail.

#no-changelog

dconeybe avatar Jun 24 '22 04:06 dconeybe

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.35% (6c8a010) to 88.40% (6c8cba3) by +0.04%.

    FilenameBase (6c8a010)Merge (6c8cba3)Diff
    exception.cc23.68%84.21%+60.53%
    exception_apple.mm96.55%65.52%-31.03%
    leveldb_key.cc98.82%98.14%-0.69%
    ordered_code.cc93.90%94.39%+0.49%
    task.cc93.91%94.78%+0.87%

Test Logs

google-oss-bot avatar Jun 24 '22 05:06 google-oss-bot

obolsete

dconeybe avatar Aug 15 '23 15:08 dconeybe