firebase-ios-sdk
firebase-ios-sdk copied to clipboard
external_rules.cmake: fail fast when preparing the external projects
This PR modifies the cmake logic that downloads and configures external projects (e.g. snappy, leveldb) so that it fails fast when the downloading and/or configuring fails. Previously, if, for example, the snappy "patch" step were to fail then cmake would happily continue on until much later things went badly, often causing difficult to diagnose errors.
This PR makes the following improvements:
- Adds logging about the commands that are being run so that it's easier to debug when things go poorly.
- Checks the result of the
execute_process()cmake function calls and fails immediately if they fail.
#no-changelog
Coverage Report 1
Affected Products
FirebaseFirestore-iOS-FirebaseFirestore.frameworkOverall coverage changed from 88.35% (6c8a010) to 88.40% (6c8cba3) by +0.04%.
Filename Base (6c8a010) Merge (6c8cba3) Diff exception.cc 23.68% 84.21% +60.53% exception_apple.mm 96.55% 65.52% -31.03% leveldb_key.cc 98.82% 98.14% -0.69% ordered_code.cc 93.90% 94.39% +0.49% task.cc 93.91% 94.78% +0.87%
Test Logs
obolsete