firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Implement the Composite Filter class

Open cherylEnkidu opened this issue 3 years ago • 3 comments

#no-changelog

  • Implement the Composite Filter class.
  • Perform parsing of AND/OR filters to create Composite Filter objects.
  • Add filter validation for composite filters.
  • Update core/query and api/query_core to handle composite filters.

cherylEnkidu avatar May 01 '22 22:05 cherylEnkidu

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (cc9c626)Merge (8c364ec)Diff
    CocoaPods6.96 MB6.97 MB+17.3 kB (+0.2%)

Test Logs

google-oss-bot avatar May 01 '22 22:05 google-oss-bot

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.59% (cc9c626) to 88.48% (8c364ec) by -0.11%.

    FilenameBase (cc9c626)Merge (8c364ec)Diff
    composite_filter.cc?50.00%?
    field_filter.cc90.18%93.44%+3.26%
    FIRQuery.mm88.00%87.69%-0.31%
    leveldb_index_manager.cc97.57%97.58%+0.01%
    leveldb_key.cc98.33%98.63%+0.29%
    query_core.cc96.20%96.26%+0.06%
    target.cc95.77%95.85%+0.08%

Test Logs

google-oss-bot avatar May 01 '22 23:05 google-oss-bot

The way the "operator" for composite filters was defined was by re-using the proto definition. It was cumbersome and inconsistent with what was done for field filters. I've made a PR (https://github.com/firebase/firebase-android-sdk/pull/3824) to fix this. Please update this PR to do the same thing. I should have made this fix earlier. Sorry for the delay.

ehsannas avatar Jun 20 '22 15:06 ehsannas