firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon firebase

make documentid decoder overload internal

Open morganchen12 opened this issue 3 years ago • 3 comments

No-longer-breaking change for #9465.

morganchen12 avatar Apr 22 '22 20:04 morganchen12

1 Warning
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot avatar Apr 22 '22 20:04 google-oss-bot

Size Report 1

Affected Products

  • FirebaseDatabase

    TypeBase (aefb2a4)Merge (7bb0b58)Diff
    CocoaPods?1.36 MB? (?)

  • FirebaseFirestore

    TypeBase (aefb2a4)Merge (7bb0b58)Diff
    CocoaPods?6.87 MB? (?)

Test Logs

google-oss-bot avatar Apr 22 '22 21:04 google-oss-bot

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.78% (aefb2a4) to 87.76% (7346304) by -0.02%.

    FilenameBase (aefb2a4)Merge (7346304)Diff
    leveldb_key.cc98.09%97.68%-0.40%
    ordered_code.cc94.15%93.41%-0.73%
    write_stream.cc90.14%94.37%+4.23%

  • FirebaseFirestore-iOS-FirebaseFirestoreSwift.framework

    Overall coverage changed from 46.48% (aefb2a4) to 46.64% (7346304) by +0.15%.

    FilenameBase (aefb2a4)Merge (7346304)Diff
    FirestoreDecoder.swift45.89%46.23%+0.34%

Test Logs

google-oss-bot avatar Apr 22 '22 22:04 google-oss-bot

@andrewheard I think you made a bunch of changes in this area that obsolete this PR. Can I close it?

morganchen12 avatar Dec 02 '22 18:12 morganchen12

@andrewheard I think you made a bunch of changes in this area that obsolete this PR. Can I close it?

Thanks for cleaning up old PRs, I need to do the same. I went ahead and closed it.

andrewheard avatar Dec 02 '22 21:12 andrewheard